Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update thrust tag to 1.17.0. #199

Closed
wants to merge 1 commit into from
Closed

Conversation

bdice
Copy link
Contributor

@bdice bdice commented May 26, 2022

This PR updates Thrust to version 1.17.0 (to be released soon) for RAPIDS 22.08. The tag format has been updated as noted in #181.

See also: rapidsai/cudf#10841

Checklist:

@bdice bdice self-assigned this May 26, 2022
@bdice bdice added 2 - In Progress Currenty a work in progress non-breaking Introduces a non-breaking change improvement Improves an existing functionality labels May 26, 2022
rapids-bot bot pushed a commit to rapidsai/cuspatial that referenced this pull request Jun 17, 2022
## Description

This PR cleans up some `#include`s for Thrust. This is meant to help with the transition to Thrust 1.17 when that is updated in rapids-cmake (rapidsai/rapids-cmake#199).

## Context

Version 1.16 of Thrust reduced the number of internal header inclusions:
> [#1572](NVIDIA/thrust#1572) Removed several unnecessary header includes. Downstream projects may need to update their includes if they were relying on this behavior.

I am making similar changes across all RAPIDS libraries to clean up includes ("include what we use," in essence) to make sure we have compatibility with future versions of Thrust.

Authors:
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - Mark Harris (https://github.com/harrism)
  - Vyas Ramasubramani (https://github.com/vyasr)

URL: #539
isVoid pushed a commit to isVoid/cuspatial that referenced this pull request Jun 23, 2022
## Description

This PR cleans up some `#include`s for Thrust. This is meant to help with the transition to Thrust 1.17 when that is updated in rapids-cmake (rapidsai/rapids-cmake#199).

## Context

Version 1.16 of Thrust reduced the number of internal header inclusions:
> [#1572](NVIDIA/thrust#1572) Removed several unnecessary header includes. Downstream projects may need to update their includes if they were relying on this behavior.

I am making similar changes across all RAPIDS libraries to clean up includes ("include what we use," in essence) to make sure we have compatibility with future versions of Thrust.

Authors:
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - Mark Harris (https://github.com/harrism)
  - Vyas Ramasubramani (https://github.com/vyasr)

URL: rapidsai#539
@bdice bdice changed the base branch from branch-22.08 to branch-22.10 August 1, 2022 19:25
@bdice
Copy link
Contributor Author

bdice commented Aug 1, 2022

Closing in favor of #231. I'll work on the libcudf changes separately.

@bdice bdice closed this Aug 1, 2022
rapids-bot bot pushed a commit that referenced this pull request Aug 11, 2022
This pulls out the Thrust bump from #227 so that we can roll out changes slowly and have an easier time to track down issues.

Once this is in and RAPIDS is happy, we can go ahead and merge #199 which has breaking changes.

Authors:
  - Robert Maynard (https://github.com/robertmaynard)

Approvers:
  - Bradley Dice (https://github.com/bdice)

URL: #231
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 - In Progress Currenty a work in progress improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant