Add view ctors that don't take erased sentinel parameter #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PointKernel
added
type: feature request
sleeepyjack
approved these changes
Jun 3, 2022
Comment on lines
+441
to
+442
| empty_key_sentinel_{empty_key_sentinel.value}, | ||
| erased_key_sentinel_{empty_key_sentinel.value}, |
There was a problem hiding this comment.
Ok, so we set the erased_key_sentinel to be the same as the empty_key_sentinel. This implies, that we must not call map.erase(...) or we break our probing scheme. In order to ensure this, we have a guard in the host API here.
However, as far as I can see, there is no such guard for the device API.
Is this by design?
There was a problem hiding this comment.
We don't really have a good way to guard it on the device API. The best would could probably do is an assert.
rapids-bot bot
pushed a commit
to rapidsai/cudf
that referenced
this pull request
Jun 7, 2022
Depends on NVIDIA/cuCollections#165 and NVIDIA/cuCollections#171 This is a preparation step to finally address #10841. It fetches the latest version of `cuco` that [adds missing thrust headers ](NVIDIA/cuCollections#161) and [improves `static_map::retrieve_all`](NVIDIA/cuCollections#169). Authors: - Yunsong Wang (https://github.com/PointKernel) Approvers: - Bradley Dice (https://github.com/bdice) - Vyas Ramasubramani (https://github.com/vyasr) URL: #10983
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
static_map::device_view/static_map::device_mutable_viewconstructors that don't take the erased sentinel parameter.It's a dependency of rapidsai/cudf#10983