Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #8372 - Incorrect transition of RoomAir:Node:AirflowNetwork:HVACEquipment from v9.2 to v9.3 #8415

Merged
merged 1 commit into from
Dec 11, 2020
Merged

Fixes #8372 - Incorrect transition of RoomAir:Node:AirflowNetwork:HVACEquipment from v9.2 to v9.3 #8415

merged 1 commit into from
Dec 11, 2020

Conversation

jmarrec
Copy link
Contributor

@jmarrec jmarrec commented Dec 9, 2020 •
edited by mjwitte
Loading

Pull request overview

The problem is due to how the move from AirTerminal:SingleDuct:Uncontrolled to AirTerminal:SingleDuct:ConstantVolume:NoReheat for this object.

Testing

See testing with https://github.com/NREL/EnergyPlusDevSupport/blob/ec4052601eebe20b3f9bf1bb59bd85866a9f5d53/DefectFiles/8000s/8372/RoomAirflowNetwork_mod.idf

Before

./Transition-V9-2-0-to-V9-3-0 /home/julien/Software/Others/EnergyPlusDevSupport/DefectFiles/8000s/8372/RoomAirflowNetwork_mod.idf
 Transition Starting
 Conversion 9.2 => 9.3
 Processing Old IDD -- V9-2-0-Energy+.idd
 Processing New IDD -- V9-3-0-Energy+.idd
 Will create new full IDFs
 Will create new IDF lines with units where applicable
 Will create new IDF lines leaving blank incoming fields as blank (no default fill)
 F
 Processing IDF -- /home/julien/Software/Others/EnergyPlusDevSupport/DefectFiles/8000s/8372/RoomAirflowNetwork_mod.idf
 ** Warning ** IP: IDF line~2883 Obsolete object=AirTerminal:SingleDuct:Uncontrolled, encountered.  Should be replaced with new object=AirTerminal:SingleDuct:ConstantVolume:NoReheat
 Processing IDF -- Processing idf objects . . .
At line 691 of file /home/julien/Software/Others/EnergyPlus/src/Transition/CreateNewIDFUsingRulesV9_3_0.f90
Fortran runtime error: Index '2' of dimension 1 of array 'atsdunodenames' above upper bound of 1

Error termination. Backtrace:
#0  0x489e7d in ???
#1  0x48a0b5 in ???
#2  0x48a487 in ???
#3  0x4184de in ???
#4  0x4029ac in ???
#5  0x40087e in ???
#6  0x4c0c48 in ???
#7  0x400e89 in ???

After

 Transition Starting
 Conversion 9.2 => 9.3
 Processing Old IDD -- V9-2-0-Energy+.idd
 Processing New IDD -- V9-3-0-Energy+.idd
 Will create new full IDFs
 Will create new IDF lines with units where applicable
 Will create new IDF lines leaving blank incoming fields as blank (no default fill)
 F
 Processing IDF -- /home/julien/Software/Others/EnergyPlusDevSupport/DefectFiles/8000s/8372/RoomAirflowNetwork_mod.idf
 ** Warning ** IP: IDF line~2883 Obsolete object=AirTerminal:SingleDuct:Uncontrolled, encountered.  Should be replaced with new object=AirTerminal:SingleDuct:ConstantVolume:NoReheat
 Processing IDF -- Processing idf objects . . .
 Processing IDF -- Processing idf objects complete.
 ************* Conversion Completed Successfully-- 1 Warning; 0 Severe Errors

The resulting IDF has the correct transition of the RoomAir:Node:AirflowNetwork:HVACEquipment:

-RoomAir:Node:AirflowNetwork:HVACEquipment,
+  RoomAir:Node:AirflowNetwork:HVACEquipment,
     LeftUpper_HVAC,          !- Name
-    AirTerminal:SingleDuct:Uncontrolled,  !- ZoneHVAC or Air Terminal Equipment Object Type 1
+    AirTerminal:SingleDuct:ConstantVolume:NoReheat,  !- ZoneHVAC or Air Terminal Equipment Object Type 1
     NORTH_ZONE PTAC,         !- ZoneHVAC or Air Terminal Equipment Object Name 1
     0.04,                    !- Fraction of Output or Supply Air from HVAC Equipment 1
     0.04;                    !- Fraction of Input or Return Air to HVAC Equipment 1
 
-RoomAir:Node:AirflowNetwork:HVACEquipment,
+  RoomAir:Node:AirflowNetwork:HVACEquipment,
     CentralUpper_HVAC,       !- Name
-    AirTerminal:SingleDuct:Uncontrolled,  !- ZoneHVAC or Air Terminal Equipment Object Type 1
+    AirTerminal:SingleDuct:ConstantVolume:NoReheat,  !- ZoneHVAC or Air Terminal Equipment Object Type 1
     NORTH_ZONE PTAC,         !- ZoneHVAC or Air Terminal Equipment Object Name 1
     0.14,                    !- Fraction of Output or Supply Air from HVAC Equipment 1
     0.14;                    !- Fraction of Input or Return Air to HVAC Equipment 1

Pull Request Author

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

  • Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
  • Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
  • Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
  • Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
  • If any diffs are expected, author must demonstrate they are justified using plots and descriptions
  • If changes fix a defect, the fix should be demonstrated in plots and descriptions
  • If any defect files are updated to a more recent version, upload new versions here or on DevSupport
  • If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
  • If structural output changes, add to output rules file and add OutputChange label
  • If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies

Reviewer

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • If branch is behind develop, merge develop and build locally to check for side effects of the merge
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified
  • Check that performance is not impacted (CI Linux results include performance check)
  • Run Unit Test(s) locally
  • Check any new function arguments for performance impacts
  • Verify IDF naming conventions and styles, memos and notes and defaults
  • If new idf included, locally check the err file and other outputs

@jmarrec jmarrec added Defect Includes code to repair a defect in EnergyPlus AuxiliaryTool Related to an auxiliary tool, not EnergyPlus itself (readvars, preprocessor, ep-launch, etc.) labels Dec 9, 2020
@jmarrec jmarrec self-assigned this Dec 9, 2020
jmarrec
jmarrec commented Dec 9, 2020
View reviewed changes
src/Transition/CreateNewIDFUsingRulesV9_3_0.f90
Comment on lines +687 to +689
NoDiff = .true.
CALL GetNewObjectDefInIDD(ObjectName,NwNumArgs,NwAorN,NwReqFld,NwObjMinFlds,NwFldNames,NwFldDefaults,NwFldUnits)
OutArgs(1) = InArgs(1)
! Loop through fields looking for AirTerminal:SingleDuct:Uncontrolled node name
DO nodeCount=2, CurArgs
IF (SameString(TRIM(InArgs(nodeCount)), TRIM(ATSDUNodeNames(atCount)))) THEN
OutArgs(nodeCount) = TRIM(InArgs(nodeCount)) // ' ATInlet'
ELSE
OutArgs(nodeCount) = InArgs(nodeCount)
OutArgs(1:CurArgs) = InArgs(1:CurArgs)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Start up by copying everything, NoDiff is true.

src/Transition/CreateNewIDFUsingRulesV9_3_0.f90
Comment on lines +690 to +698
! Loop through "ZoneHVAC or Air Terminal Equipment Object Type" fields looking for
! "AirTerminal:SingleDuct:Uncontrolled" and replace with "AirTerminal:SingleDuct:ConstantVolume:NoReheat"
! Four extensible fields
DO CurField=2, CurArgs-1, 4
IF (SameString(TRIM(InArgs(CurField)),'AirTerminal:SingleDuct:Uncontrolled')) THEN
OutArgs(CurField) = 'AirTerminal:SingleDuct:ConstantVolume:NoReheat'
NoDiff = .false.
END IF
ENDDO
NoDiff = .false.
END DO
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then check every "ZoneHVAC or Air Terminal Equipment Object Type", if ATU:SngleDuct:Uncontrolled => replace and set NoDiff = false

@mjwitte
Copy link
Contributor

mjwitte commented Dec 11, 2020

@jmarrec The transition results look good, but the file fails:

   ** Severe  ** GetRoomAirflowNetworkData: The equipment listed in ZoneEquipList is not found in the lsit of RoomAir:Node:AirflowNetwork:HVACEquipment objects =
   **   ~~~   ** NORTH_ZONE PTAC ADU. Please check inputs of both objects.

My guess is that this object doesn't work with any of the airterminal units, because this code here is looking for the terminal unit type and name on the ZoneHVAC:EquipmentList. But air terminals don't live directly on the equipment list, they are a child of a ZoneHVAC:AirDistributionUnit. I'm going to merge this and open a new issue.

@mjwitte mjwitte merged commit 6cb98b4 into develop Dec 11, 2020
@mjwitte mjwitte deleted the 8372_Transition_RoomAirflowNetwork_v920_v930 branch December 11, 2020 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jmarrec jmarrec

Labels
AuxiliaryTool Related to an auxiliary tool, not EnergyPlus itself (readvars, preprocessor, ep-launch, etc.) Defect Includes code to repair a defect in EnergyPlus
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect transition of RoomAir:Node:AirflowNetwork:HVACEquipment from v9.2 to v9.3
6 participants
@jmarrec @mjwitte @nrel-bot @nrel-bot-3 @nrel-bot-2b @nrel-bot-2c