Incorrect transition of RoomAir:Node:AirflowNetwork:HVACEquipment from v9.2 to v9.3

[hongyuanjia]

In EnergyPlus v9.3, class AirTerminal:SingleDuct:Uncontrolled has been converted to new class AirTerminal:SingleDuct:ConstantVolume:NoReheat. Looking through the corresponding transition code, I found that class RoomAir:Node:AirflowNetwork:HVACEquipment may not be treated correctly:

EnergyPlus/src/Transition/CreateNewIDFUsingRulesV9_3_0.f90

Lines 685 to 702 in 7495909

	CASE('ROOMAIR:NODE:AIRFLOWNETWORK:HVACEQUIPMENT')
	IF(TotATSDUObjs > 0) THEN
	CALL GetNewObjectDefInIDD(ObjectName,NwNumArgs,NwAorN,NwReqFld,NwObjMinFlds,NwFldNames,NwFldDefaults,NwFldUnits)
	OutArgs(1) = InArgs(1)
	! Loop through fields looking for AirTerminal:SingleDuct:Uncontrolled node name
	DO nodeCount=2, CurArgs
	IF (SameString(TRIM(InArgs(nodeCount)), TRIM(ATSDUNodeNames(atCount)))) THEN
	OutArgs(nodeCount) = TRIM(InArgs(nodeCount)) // ' ATInlet'
	ELSE
	OutArgs(nodeCount) = InArgs(nodeCount)
	END IF
	ENDDO
	NoDiff = .false.
	ELSE
	CALL GetNewObjectDefInIDD(ObjectName,NwNumArgs,NwAorN,NwReqFld,NwObjMinFlds,NwFldNames,NwFldDefaults,NwFldUnits)
	OutArgs(1:CurArgs)=InArgs(1:CurArgs)
	NoDiff=.true.
	ENDIF

The code above basically tries to append the original AirTerminal:SingleDuct:Uncontrolled node with suffix ATInlet starting from 2nd field. However, according to IDD v9.2, the 2nd field is a choice field which can be AirTerminal:SingleDuct:Uncontrolled, and there is no way that any fields can be a node. The code above will do nothing if an AirTerminal:SingleDuct:Uncontrolled is referenced in Field 2 and Field 3.

#   1: Name
#   2: ZoneHVAC or Air Terminal Equipment Object Type 1
#   3: ZoneHVAC or Air Terminal Equipment Object Name 1
#   4: Fraction of Output or Supply Air from HVAC Equipment 1
#   5: Fraction of Input or Return Air to HVAC Equipment 1
#    ......

The proper way to transition this class is to follow the same logic as in the ZoneHVAC:EquipmentList:

EnergyPlus/src/Transition/CreateNewIDFUsingRulesV9_3_0.f90

Lines 473 to 489 in 7495909

	CASE('ZONEHVAC:EQUIPMENTLIST')
	nodiff = .false.
	CALL GetNewObjectDefInIDD(ObjectName,NwNumArgs,NwAorN,NwReqFld,NwObjMinFlds,NwFldNames,NwFldDefaults,NwFldUnits)
	DO CurField = 1, CurArgs
	! Add air terminal unit object type and name change here (see AirTerminal:SingleDuct:Uncontrolled above)
	IF (CurField > 2) THEN
	IF (SameString(TRIM(InArgs(CurField)),'AirTerminal:SingleDuct:Uncontrolled')) THEN
	OutArgs(CurField) = 'ZoneHVAC:AirDistributionUnit'
	ELSE IF (SameString(TRIM(InArgs(CurField-1)),'AirTerminal:SingleDuct:Uncontrolled')) THEN
	OutArgs(CurField) = TRIM(InArgs(CurField)) // ' ADU'
	ELSE
	OutArgs(CurField) = InArgs(CurField)
	END IF
	ELSE
	OutArgs(CurField) = InArgs(CurField)
	END IF
	END DO

Hope above helps.

Details

Some additional details for this issue (if relevant):

• Version of EnergyPlus 9.2.0 to 9.3.0

Checklist

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

• Defect file: https://github.com/NREL/EnergyPlusDevSupport/blob/ec4052601eebe20b3f9bf1bb59bd85866a9f5d53/DefectFiles/8000s/8372/RoomAirflowNetwork_mod.idf
• Ticket added to Pivotal for defect (development team task)
• Pull request created (the pull request will have additional tasks related to reviewing changes that fix this defect)

[mjwitte]

@hongyuanjia If you have a file with this combination of objects that can be used for testing, that would be appreciated.

[jmarrec]

@hongyuanjia Do you have a file please.?

[hongyuanjia]

@jmarrec, I modified the example file RoomAirflowNetwork.idf to include the case I mentioned.

RoomAirflowNetwork.idf.txt

[jmarrec]

@hongyuanjia Thank you!

I added the details and checklist from the issue template to your original post.