Fixes #8372 - Incorrect transition of RoomAir:Node:AirflowNetwork:HVA…

…CEquipment from v9.2 to v9.3 See testing with https://github.com/NREL/EnergyPlusDevSupport/blob/ec4052601eebe20b3f9bf1bb59bd85866a9f5d53/DefectFiles/8000s/8372/RoomAirflowNetwork_mod.idf
NREL · Dec 8, 2020 · 7df1389 · 7df1389 · nrel-bot-3 · Dec 9, 2020
1 parent 7f35ab6
commit 7df1389
Showing 1 changed file with 10 additions and 9 deletions.
diff --git a/src/Transition/CreateNewIDFUsingRulesV9_3_0.f90 b/src/Transition/CreateNewIDFUsingRulesV9_3_0.f90
@@ -684,17 +684,18 @@ SUBROUTINE CreateNewIDFUsingRules(EndOfFile,DiffOnly,InLfn,AskForInput,InputFile
               ! Wait - there's more for the transition for AirTerminal:SingleDuct:Uncontrolled
               CASE('ROOMAIR:NODE:AIRFLOWNETWORK:HVACEQUIPMENT')
               IF(TotATSDUObjs > 0) THEN
+                 NoDiff = .true.
                  CALL GetNewObjectDefInIDD(ObjectName,NwNumArgs,NwAorN,NwReqFld,NwObjMinFlds,NwFldNames,NwFldDefaults,NwFldUnits)
-                 OutArgs(1) = InArgs(1)
-                 ! Loop through fields looking for  AirTerminal:SingleDuct:Uncontrolled node name
-                 DO nodeCount=2, CurArgs
-                   IF (SameString(TRIM(InArgs(nodeCount)), TRIM(ATSDUNodeNames(atCount)))) THEN
-                     OutArgs(nodeCount) = TRIM(InArgs(nodeCount)) // ' ATInlet'
-                   ELSE
-                     OutArgs(nodeCount) = InArgs(nodeCount)
+                 OutArgs(1:CurArgs) = InArgs(1:CurArgs)
+                 ! Loop through "ZoneHVAC or Air Terminal Equipment Object Type" fields looking for
+                 ! "AirTerminal:SingleDuct:Uncontrolled" and replace with "AirTerminal:SingleDuct:ConstantVolume:NoReheat"
+                 ! Four extensible fields
+                 DO CurField=2, CurArgs-1, 4
+                   IF (SameString(TRIM(InArgs(CurField)),'AirTerminal:SingleDuct:Uncontrolled')) THEN
+                     OutArgs(CurField) = 'AirTerminal:SingleDuct:ConstantVolume:NoReheat'
+                     NoDiff = .false.
                    END IF
-                 ENDDO
-                NoDiff = .false.
+                 END DO
               ELSE
                 CALL GetNewObjectDefInIDD(ObjectName,NwNumArgs,NwAorN,NwReqFld,NwObjMinFlds,NwFldNames,NwFldDefaults,NwFldUnits)
                 OutArgs(1:CurArgs)=InArgs(1:CurArgs)