-
Notifications
You must be signed in to change notification settings - Fork 389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement new swimming pool simulation model #4559
Changes from 13 commits
5501d34
63aaee4
a711742
ca14201
1f64de4
fd984ae
6da256b
ff47e7f
d7e1664
e02d190
bffe800
5e1c4a0
cc8768e
5dbed15
d85d68e
c6d58f9
3db6c68
beef2b8
beef001
60ffd04
beef398
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -37481,6 +37481,91 @@ ZoneHVAC:VentilatedSlab:SlabGroup, | |
A41 ; \field Slab Outlet Node Name for Surface 10 | ||
\type node | ||
|
||
\group Zone HVAC Swimming Pools | ||
|
||
SwimmingPool:Indoor, | ||
A1, \field Name | ||
\required-field | ||
\type alpha | ||
A2, \field Surface Name | ||
\required-field | ||
\note To be matched with a construction in this input file | ||
\type object-list | ||
\object-list ConstructionNames | ||
\reference SurfaceNames | ||
\reference SurfAndSubSurfNames | ||
\reference AllHeatTranSurfNames | ||
\reference HeatTranBaseSurfNames | ||
\reference OutFaceEnvNames | ||
\reference AllHeatTranAngFacNames | ||
\reference RadGroupAndSurfNames | ||
\reference SurfGroupAndHTSurfNames | ||
\reference AllShadingAndHTSurfNames | ||
N1, \field Average Depth | ||
\required-field | ||
\type real | ||
\units m | ||
A3, \field Activity Factor Schedule Name | ||
\required-field | ||
\type object-list | ||
\object-list ScheduleNames | ||
A4, \field Make-up Water Supply Schedule Name | ||
\required-field | ||
\type object-list | ||
\object-list ScheduleNames | ||
A5, \field Cover Schedule Name | ||
\required-field | ||
\type object-list | ||
\object-list ScheduleNames | ||
N2, \field Cover Evaporation Factor | ||
\type real | ||
\minimum 0.0 | ||
\maximum 1.0 | ||
\default 0.0 | ||
N3, \field Cover Convection Factor | ||
\type real | ||
\minimum 0.0 | ||
\maximum 1.0 | ||
\default 0.0 | ||
N4, \field Cover Short-Wavelength Radiation Factor | ||
\type real | ||
\minimum 0.0 | ||
\maximum 1.0 | ||
\default 0.0 | ||
N5, \field Cover Long-Wavelength Radiation Factor | ||
\required-field | ||
\type real | ||
\minimum 0.0 | ||
\maximum 1.0 | ||
\default 0.0 | ||
A6, \field Pool Water Inlet Node | ||
\required-field | ||
\type node | ||
A7, \field Pool Water Outlet Node | ||
\required-field | ||
\type node | ||
N6, \field Pool Heating System Water Maximum Flow Rate | ||
\type real | ||
\units m3/s | ||
\minimum 0.0 | ||
N7, \field Pool Miscellaneous Equipment Power | ||
\units W/(kg/s of pool water flow) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is not a valid unit - standard units are listed at the top of the IDD. Would be much better if this were per volume flow rate instead of mass flow - since the volume flow rate is in the field above. That would make the units W/(m3/s). |
||
\type real | ||
\minimum 0.0 | ||
A8, \field Setpoint Temperature Schedule | ||
\required-field | ||
\type object-list | ||
\object-list ScheduleNames | ||
N8, \field Maximum Number of People | ||
\required-field | ||
\minimum 0.0 | ||
A9, \field People Schedule | ||
\type object-list | ||
\object-list ScheduleNames | ||
A10; \field People Heat Gain Schedule | ||
\type object-list | ||
\object-list ScheduleNames | ||
|
||
\group Zone HVAC Air Loop Terminal Units | ||
|
||
AirTerminal:SingleDuct:Uncontrolled, | ||
|
@@ -91626,4 +91711,3 @@ Output:PreprocessorMessage, | |
\retaincase | ||
A12; \field Message Line 10 | ||
\retaincase | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RKStrand Is this a surface name or construction name? \reference does not apply here, only \object-list. There may be multiple \object-list if needed. If this is a construction name, then that's what the field name should be. If it's a surface name, then it should be \object-list
I agree with @Myoldmopar that this should not make a new IDD group. I would put it in the Internal Gains group, perhaps right after zonebaseboard:outdoortemperaturecontrolled?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RKStrand Would this be correct? \object-list HeatTranBaseSurfNames
This reference exists but is never used anywhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it has to be a base surface…a floor to be specific. So, the list should probably only be HeatTranBaseSurfNames. Do you mean that it is never used anywhere in the IDD?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RKStrand Correct, there are several \reference HeatTranBaseSurfNames to establish which objects are part of this group, but I did not see any \object-list HeatTranBaseSurfNames. If you want to make it exclusive to floors, the perhaps you want to make a new reference name just for objects which could be a floor (that's just two or three classes, I think).