Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement new swimming pool simulation model #4559

Merged
merged 21 commits into from
Dec 12, 2014
Merged

Implement new swimming pool simulation model #4559

merged 21 commits into from
Dec 12, 2014

Commits on Oct 17, 2014

  1. Initial changes for the swimming pool model 

    Mostly supporting changes (get input, init, module shell, etc.) for the
swimming pool model; committing mostly to back things up
    @RKStrand
    RKStrand committed Oct 17, 2014
    Configuration menu
    Copy the full SHA
    5501d34 View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2014

  1. more swimming pool changes 

    more code updates
    @RKStrand
    RKStrand committed Oct 20, 2014
    6 Configuration menu
    Copy the full SHA
    63aaee4 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2014

  1. swimming pool more code added 

    added more code, still a work in progress
    @RKStrand
    RKStrand committed Oct 21, 2014
    6 Configuration menu
    Copy the full SHA
    a711742 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2014

  1. first draft of swimming pool model 

    all changes that should be necessary to get this to work, starting
debugging from here
    @RKStrand
    RKStrand committed Oct 24, 2014
    Configuration menu
    Copy the full SHA
    ca14201 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2014

  1. bugs that caused compile/link issues 

    fixed problems
    @RKStrand
    RKStrand committed Oct 25, 2014
    Configuration menu
    Copy the full SHA
    1f64de4 View commit details
    Browse the repository at this point in the history

  2. Changes to the IDD file 

    addition of the swimming pool (indoor) input
    @RKStrand
    RKStrand committed Oct 25, 2014
    2 Configuration menu
    Copy the full SHA
    fd984ae View commit details
    Browse the repository at this point in the history

  3. Fixed bug in get input 

    pool cover value was not being limited to the 0.0-1.0 range properly
    @RKStrand
    RKStrand committed Oct 25, 2014
    Configuration menu
    Copy the full SHA
    6da256b View commit details
    Browse the repository at this point in the history

  4. Final changes to swimming pool 

    Final changes to get the indoor swimming pool model to work; includes
IDD addition and input file test case (annual run); results seem to
indicate that the model is working properly
    @RKStrand
    RKStrand committed Oct 25, 2014
    2 Configuration menu
    Copy the full SHA
    ff47e7f View commit details
    Browse the repository at this point in the history

  5. enhancement to a couple of output variables 

    added information to monitor certain output variables more appropriately
    @RKStrand
    RKStrand committed Oct 25, 2014
    2 Configuration menu
    Copy the full SHA
    d7e1664 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2014

  1. fix to eliminate warning messages 

    during the standard test suite run, a warning message was uncovered.
this bug has now been fixed
    @RKStrand
    RKStrand committed Oct 26, 2014
    6 Configuration menu
    Copy the full SHA
    e02d190 View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2014

  1. Merged develop into this branch; resolved IDD conflicts

    @Myoldmopar
    Myoldmopar committed Oct 29, 2014
    6 Configuration menu
    Copy the full SHA
    bffe800 View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2014

  1. Trying line ending conversion to resolve idd re-write issue

    @Myoldmopar
    Myoldmopar committed Oct 30, 2014
    Configuration menu
    Copy the full SHA
    5e1c4a0 View commit details
    Browse the repository at this point in the history

  2. Add idf to testfiles/CMakeLists so it is included in testing

    @Myoldmopar
    Myoldmopar committed Oct 30, 2014
    4 Configuration menu
    Copy the full SHA
    cc8768e View commit details
    Browse the repository at this point in the history

  3. Moved IDD into internal gains section, renamed field N6.

    @Myoldmopar
    Myoldmopar committed Oct 30, 2014
    6 Configuration menu
    Copy the full SHA
    5dbed15 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2014

  1. Fix to correct when inside heat balance is called 

    Swimming pool model was calling the inside heat balance even when there
were no pools.  This was causing diffs and other strangeness which
should be corrected with this fix.
    @RKStrand
    RKStrand committed Oct 31, 2014
    4 Configuration menu
    Copy the full SHA
    d85d68e View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/develop' into 972110-SwimmingPool

    @Myoldmopar
    Myoldmopar committed Oct 31, 2014
    6 Configuration menu
    Copy the full SHA
    c6d58f9 View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2014

  1. correction to handling of convective cover gains 

    as per review comments from Brent, moved the cover convective gains to
the occupied region of the zone rather than the upper region
    @RKStrand
    RKStrand committed Nov 3, 2014
    6 Configuration menu
    Copy the full SHA
    3db6c68 View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2014

  1. Merge develop into this branch, resolve conflicts; 

    [#972110]
    @Myoldmopar
    Myoldmopar committed Nov 24, 2014
    6 Configuration menu
    Copy the full SHA
    beef2b8 View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2014

  1. Fix build errors

    @Myoldmopar
    Myoldmopar committed Nov 25, 2014
    6 Configuration menu
    Copy the full SHA
    beef001 View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2014

  1. Changes to input for power factor 

    Changes requested by @mjwitte regarding the power factor being a
function of volumetric flow rate rather than mass flow rate
    @RKStrand
    RKStrand committed Nov 28, 2014
    7 Configuration menu
    Copy the full SHA
    60ffd04 View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2014

  1. Correct the ValidLoopEquipTypes array in DataPlant

    @Myoldmopar
    Myoldmopar committed Dec 9, 2014
    6 Configuration menu
    Copy the full SHA
    beef398 View commit details
    Browse the repository at this point in the history