Skip to content

Commit

Permalink
correction to handling of convective cover gains
Browse files Browse the repository at this point in the history
as per review comments from Brent, moved the cover convective gains to
the occupied region of the zone rather than the upper region
  • Loading branch information
RKStrand committed Nov 3, 2014
1 parent c6d58f9 commit 3db6c68
Showing 1 changed file with 8 additions and 2 deletions.
10 changes: 8 additions & 2 deletions src/EnergyPlus/UFADManager.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1062,11 +1062,14 @@ namespace UFADManager {
SumReturnAirConvectionGainsByTypes( ZoneNum, IntGainTypesOccupied, RetAirGains );
ConvGainsOccSubzone += RetAirGains;
}

// Add convection from pool cover to occupied region
ConvGainsOccSubzone += SumConvPool( ZoneNum );

// gains from lights (ceiling), tubular daylighting devices, high temp radiant heaters

SumInternalConvectionGainsByTypes( ZoneNum, IntGainTypesUpSubzone, ConvGainsUpSubzone );
ConvGainsUpSubzone += SumConvHTRadSys( ZoneNum ) + SumConvPool( ZoneNum );
ConvGainsUpSubzone += SumConvHTRadSys( ZoneNum );
if ( Zone( ZoneNum ).NoHeatToReturnAir ) {
SumReturnAirConvectionGainsByTypes( ZoneNum, IntGainTypesUpSubzone, RetAirGains );
ConvGainsUpSubzone += RetAirGains;
Expand Down Expand Up @@ -1484,9 +1487,12 @@ namespace UFADManager {
ConvGainsOccSubzone += RetAirGains;
}

// Add convection from pool cover to occupied region
ConvGainsOccSubzone += SumConvPool( ZoneNum );

// gains from lights (ceiling), tubular daylighting devices, high temp radiant heaters
SumInternalConvectionGainsByTypes( ZoneNum, IntGainTypesUpSubzone, ConvGainsUpSubzone );
ConvGainsUpSubzone += SumConvHTRadSys( ZoneNum ) + SumConvPool( ZoneNum );
ConvGainsUpSubzone += SumConvHTRadSys( ZoneNum );
if ( Zone( ZoneNum ).NoHeatToReturnAir ) {
SumReturnAirConvectionGainsByTypes( ZoneNum, IntGainTypesUpSubzone, RetAirGains );
ConvGainsUpSubzone += RetAirGains;
Expand Down

6 comments on commit 3db6c68

@nrel-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

972110-SwimmingPool (RKStrand) - x86_64-MacOS-10.9-clang: OK (970 of 970 tests passed)

Build Badge Test Badge

@nrel-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

972110-SwimmingPool (RKStrand) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (970 of 970 tests passed)

Build Badge Test Badge

@nrel-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

972110-SwimmingPool (RKStrand) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

Build Badge

@nrel-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

972110-SwimmingPool (RKStrand) - x86_64-MacOS-10.9-clang-Debug: OK (970 of 970 tests passed)

Build Badge Test Badge

@nrel-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

972110-SwimmingPool (RKStrand) - i386-Windows-7-VisualStudio-12: OK (970 of 970 tests passed)

Build Badge Test Badge

@nrel-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

972110-SwimmingPool (RKStrand) - Win64-Windows-7-VisualStudio-12: OK (970 of 970 tests passed)

Build Badge Test Badge

Please sign in to comment.