Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement new swimming pool simulation model #4559

Merged
merged 21 commits into from
Dec 12, 2014
Merged

Implement new swimming pool simulation model #4559

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
5501d34
Initial changes for the swimming pool model
RKStrand Oct 17, 2014
63aaee4
more swimming pool changes
RKStrand Oct 20, 2014
a711742
swimming pool more code added
RKStrand Oct 21, 2014
ca14201
first draft of swimming pool model
RKStrand Oct 24, 2014
1f64de4
bugs that caused compile/link issues
RKStrand Oct 25, 2014
fd984ae
Changes to the IDD file
RKStrand Oct 25, 2014
6da256b
Fixed bug in get input
RKStrand Oct 25, 2014
ff47e7f
Final changes to swimming pool
RKStrand Oct 25, 2014
d7e1664
enhancement to a couple of output variables
RKStrand Oct 25, 2014
e02d190
fix to eliminate warning messages
RKStrand Oct 26, 2014
bffe800
Merged develop into this branch; resolved IDD conflicts
Myoldmopar Oct 29, 2014
5e1c4a0
Trying line ending conversion to resolve idd re-write issue
Myoldmopar Oct 30, 2014
cc8768e
Add idf to testfiles/CMakeLists so it is included in testing
Myoldmopar Oct 30, 2014
5dbed15
Moved IDD into internal gains section, renamed field N6.
Myoldmopar Oct 30, 2014
d85d68e
Fix to correct when inside heat balance is called
RKStrand Oct 31, 2014
c6d58f9
Merge remote-tracking branch 'origin/develop' into 972110-SwimmingPool
Myoldmopar Oct 31, 2014
3db6c68
correction to handling of convective cover gains
RKStrand Nov 3, 2014
beef2b8
Merge develop into this branch, resolve conflicts;
Myoldmopar Nov 24, 2014
beef001
Fix build errors
Myoldmopar Nov 25, 2014
60ffd04
Changes to input for power factor
RKStrand Nov 28, 2014
beef398
Correct the ValidLoopEquipTypes array in DataPlant
Myoldmopar Dec 9, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
85 changes: 84 additions & 1 deletion idd/Energy+.idd.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20005,6 +20005,90 @@ ZoneBaseboard:OutdoorTemperatureControlled,
\retaincase
\default General


SwimmingPool:Indoor,
A1, \field Name
\required-field
\type alpha
A2, \field Surface Name
\required-field
\note To be matched with a construction in this input file
\type object-list
\object-list ConstructionNames
\reference SurfaceNames
\reference SurfAndSubSurfNames
\reference AllHeatTranSurfNames
\reference HeatTranBaseSurfNames
\reference OutFaceEnvNames
\reference AllHeatTranAngFacNames
\reference RadGroupAndSurfNames
\reference SurfGroupAndHTSurfNames
\reference AllShadingAndHTSurfNames
N1, \field Average Depth
\required-field
\type real
\units m
A3, \field Activity Factor Schedule Name
\required-field
\type object-list
\object-list ScheduleNames
A4, \field Make-up Water Supply Schedule Name
\required-field
\type object-list
\object-list ScheduleNames
A5, \field Cover Schedule Name
\required-field
\type object-list
\object-list ScheduleNames
N2, \field Cover Evaporation Factor
\type real
\minimum 0.0
\maximum 1.0
\default 0.0
N3, \field Cover Convection Factor
\type real
\minimum 0.0
\maximum 1.0
\default 0.0
N4, \field Cover Short-Wavelength Radiation Factor
\type real
\minimum 0.0
\maximum 1.0
\default 0.0
N5, \field Cover Long-Wavelength Radiation Factor
\required-field
\type real
\minimum 0.0
\maximum 1.0
\default 0.0
A6, \field Pool Water Inlet Node
\required-field
\type node
A7, \field Pool Water Outlet Node
\required-field
\type node
N6, \field Pool Heating System Maximum Water Flow Rate
\type real
\units m3/s
\minimum 0.0
N7, \field Pool Miscellaneous Equipment Power
\units W/(m3/s of pool water flow)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RKStrand @Myoldmopar @kbenne These units are invalid. Needs to be "W/(m3/s)" then add a
\note Power per unit of pool water flow.
Noticed this when IDF Editor complained while working on a different issue. Should get this fixed before making the performance update build. This happens frequently (IDD errors) - we need an IDD validation step in the CI system. Noting this here and will post a fix shortly.

\type real
\minimum 0.0
A8, \field Setpoint Temperature Schedule
\required-field
\type object-list
\object-list ScheduleNames
N8, \field Maximum Number of People
\required-field
\minimum 0.0
A9, \field People Schedule
\type object-list
\object-list ScheduleNames
A10; \field People Heat Gain Schedule
\type object-list
\object-list ScheduleNames

ZoneContaminantSourceAndSink:CarbonDioxide,
\memo Represents internal CO2 gains and sinks in the zone.
A1 , \field Name
Expand Down Expand Up @@ -91763,4 +91847,3 @@ Output:PreprocessorMessage,
\retaincase
A12; \field Message Line 10
\retaincase

2 changes: 2 additions & 0 deletions src/EnergyPlus/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -433,6 +433,8 @@ SET( SRC
SurfaceGeometry.hh
SurfaceGroundHeatExchanger.cc
SurfaceGroundHeatExchanger.hh
SwimmingPool.cc
SwimmingPool.hh
SystemAvailabilityManager.cc
SystemAvailabilityManager.hh
SystemReports.cc
Expand Down
2 changes: 1 addition & 1 deletion src/EnergyPlus/CrossVentMgr.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -831,7 +831,7 @@ namespace CrossVentMgr {
}

SumAllInternalConvectionGains( ZoneNum, ConvGains );
ConvGains += SumConvHTRadSys( ZoneNum ) + SysDepZoneLoadsLagged( ZoneNum ) + NonAirSystemResponse( ZoneNum ) / ZoneMult;
ConvGains += SumConvHTRadSys( ZoneNum ) + SumConvPool( ZoneNum ) + SysDepZoneLoadsLagged( ZoneNum ) + NonAirSystemResponse( ZoneNum ) / ZoneMult;

// Add heat to return air if zonal system (no return air) or cycling system (return air frequently very low or zero)
if ( Zone( ZoneNum ).NoHeatToReturnAir ) {
Expand Down
6 changes: 5 additions & 1 deletion src/EnergyPlus/DataHeatBalFanSys.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,8 @@ namespace DataHeatBalFanSys {
// MODULE VARIABLE DECLARATIONS:
FArray1D< Real64 > SumConvHTRadSys; // Sum of convection to zone air from hi temp radiant heaters
FArray1D< Real64 > SumLatentHTRadSys; // Sum of latent gains from hi temp radiant heaters
FArray1D< Real64 > SumConvPool; // Sum of convection to zone air from pools
FArray1D< Real64 > SumLatentPool; // Sum of latent gains from pools
FArray1D< Real64 > QHTRadSysToPerson; // Sum of radiant gains to people from hi temp radiant heaters
FArray1D< Real64 > QHWBaseboardToPerson; // Sum of radiant gains to people from hot water baseboard heaters
FArray1D< Real64 > QSteamBaseboardToPerson; // Sum of radiant gains to people from steam baseboard heaters
Expand Down Expand Up @@ -138,6 +140,8 @@ namespace DataHeatBalFanSys {
// of steam baseboard heaters
FArray1D< Real64 > QElecBaseboardSurf; // Current radiant heat flux at a surface due to the presence
// of electric baseboard heaters
FArray1D< Real64 > QPoolSurfNumerator; // Current pool heat flux impact at the surface (numerator of surface heat balance)
FArray1D< Real64 > PoolHeatTransCoefs; // Current pool heat transfer coefficients (denominator of surface heat balance)
FArray1D< Real64 > RadSysTiHBConstCoef; // Inside heat balance coefficient that is constant
FArray1D< Real64 > RadSysTiHBToutCoef; // Inside heat balance coefficient that modifies Toutside
FArray1D< Real64 > RadSysTiHBQsrcCoef; // Inside heat balance coefficient that modifies source/sink
Expand Down Expand Up @@ -187,7 +191,7 @@ namespace DataHeatBalFanSys {
FArray1D< ZoneComfortControlsFangerData > ZoneComfortControlsFanger;

// NOTICE
// Copyright � 1996-2014 The Board of Trustees of the University of Illinois
// Copyright � 1996-2014 The Board of Trustees of the University of Illinois
// and The Regents of the University of California through Ernest Orlando Lawrence
// Berkeley National Laboratory. All rights reserved.
// Portions of the EnergyPlus software package have been developed and copyrighted
Expand Down
4 changes: 4 additions & 0 deletions src/EnergyPlus/DataHeatBalFanSys.hh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,8 @@ namespace DataHeatBalFanSys {
// MODULE VARIABLE DECLARATIONS:
extern FArray1D< Real64 > SumConvHTRadSys; // Sum of convection to zone air from hi temp radiant heaters
extern FArray1D< Real64 > SumLatentHTRadSys; // Sum of latent gains from hi temp radiant heaters
extern FArray1D< Real64 > SumConvPool; // Sum of convection to zone air from pools
extern FArray1D< Real64 > SumLatentPool; // Sum of latent gains from pools
extern FArray1D< Real64 > QHTRadSysToPerson; // Sum of radiant gains to people from hi temp radiant heaters
extern FArray1D< Real64 > QHWBaseboardToPerson; // Sum of radiant gains to people from hot water baseboard heaters
extern FArray1D< Real64 > QSteamBaseboardToPerson; // Sum of radiant gains to people from steam baseboard heaters
Expand Down Expand Up @@ -130,6 +132,8 @@ namespace DataHeatBalFanSys {
// of steam baseboard heaters
extern FArray1D< Real64 > QElecBaseboardSurf; // Current radiant heat flux at a surface due to the presence
// of electric baseboard heaters
extern FArray1D< Real64 > QPoolSurfNumerator; // Current pool heat flux impact at the surface (numerator of surface heat balance)
extern FArray1D< Real64 > PoolHeatTransCoefs; // Current pool heat transfer coefficients (denominator of surface heat balance)
extern FArray1D< Real64 > RadSysTiHBConstCoef; // Inside heat balance coefficient that is constant
extern FArray1D< Real64 > RadSysTiHBToutCoef; // Inside heat balance coefficient that modifies Toutside
extern FArray1D< Real64 > RadSysTiHBQsrcCoef; // Inside heat balance coefficient that modifies source/sink
Expand Down
Loading