-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update hydrotools.metrics
to newer Python versions
#261
Conversation
All tests past. Going to do a test deployment to see if classifiers/hooks get picked up correctly without |
Deployment looked good. Just needed to revert 7519e7d We'll adopt the new license once the updated GH policy is released. |
c9b0932 related to: https://nvd.nist.gov/vuln/detail/CVE-2024-6345 Thanks @aaraney ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me! Thanks, @jarq6c!
@@ -44,7 +44,7 @@ def mean_error( | |||
power: float = 1.0, | |||
root: bool = False | |||
) -> float: | |||
"""Compute the mean error or deviation. Default is Mean Absolute Error. The mean error | |||
r"""Compute the mean error or deviation. Default is Mean Absolute Error. The mean error |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the first time i've seen a docstring defined as a raw string literal. I assume this avoids character escaping headaches in the latex expressions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, the expressions were raising DeprecationWarnings and this was the easiest solution.
This PR updates the
hydrotools.metrics
package to test on Python versions 3.9, 3.10, and 3.11. It also transitions the package from using asetup.cfg
to just usingpyproject.toml
.Additions
Removals
setup.cfg
Changes
pyproject.toml
Testing
Notes
Todos
Checklist