Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate setup.cfg to pyproject.toml #263

Merged
merged 7 commits into from
Nov 19, 2024
Merged

Conversation

aaraney
Copy link
Member

@aaraney aaraney commented Nov 19, 2024

  • Update github actions imports actions/setup-python -> @5; actions/checkout -> @v4
  • Test all subpackages in ci w/ 3.11 and 3.12.
  • Migrate all subpackage metadata files from setup.cfg to pyproject.toml.
  • Bump all subpackage patch versions
  • Related to Update automated testing #259

@aaraney
Copy link
Member Author

aaraney commented Nov 19, 2024

@jarq6c, hydrotools.caches tests are failing for python 3.9. It looks like a clean up condition that might need a guard clause. I verified that the later versions of python (>3.9) in the test matrix are using a later version, 3.10.1, of tables. It looks like tables 3.10.0 dropped support for python<3.10.

Edit: Seems to be the same numpy / tables / python version issue that was causing the hydrtools.nwm_client_new on 3.9 to fail.

@aaraney
Copy link
Member Author

aaraney commented Nov 19, 2024

@jarq6c, I think the hydrotools.nwm_client_new 3.9 tests are failing for a similar reason. My best guess is the wheel pulled for tables==3.9.2 (version in failing tests) was compiled with numpy<2 but notice the test runner is pulling numpy>=2. So, there are ABI issues when tables goes to call numpy functions.

If that is the case, we should be able to remedy this by conditionally requiring numpy<2 for python<3.10.

aaraney added a commit to aaraney/hydrotools that referenced this pull request Nov 19, 2024
@aaraney
Copy link
Member Author

aaraney commented Nov 19, 2024

Looks like 9b9fcfa fixed the hydrotools.nwm_client_new test failures.

@aaraney
Copy link
Member Author

aaraney commented Nov 19, 2024

Looks like 17c0090 fixed the hydrotools.caches test failures.

@aaraney aaraney requested a review from jarq6c November 19, 2024 21:28
@jarq6c
Copy link
Collaborator

jarq6c commented Nov 19, 2024

Thanks for tackling all these @aaraney ! I had originally planned to bump the patch versions of all these packages with these changes. What do you think?

@aaraney
Copy link
Member Author

aaraney commented Nov 19, 2024

@jarq6c, yeah that is cool with me. Ill do that now.

@jarq6c jarq6c merged commit 45a2d18 into NOAA-OWP:main Nov 19, 2024
35 checks passed
@aaraney aaraney deleted the move_to_pyproject branch November 19, 2024 21:55
@aaraney
Copy link
Member Author

aaraney commented Nov 19, 2024

Thanks for the review, @jarq6c 🎉!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants