Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update automated testing #259

Closed
jarq6c opened this issue Oct 30, 2024 · 3 comments · Fixed by #264
Closed

Update automated testing #259

jarq6c opened this issue Oct 30, 2024 · 3 comments · Fixed by #264
Assignees
@jarq6c
Labels
enhancement New feature or request

Comments

@jarq6c
Copy link
Collaborator

jarq6c commented Oct 30, 2024

Python 3.8 is EOL as of 2024-10-07. We need to update the automated tests and PyPI classifiers of all packages. I'm thinking we should target the three versions that are out of "bugfix" status and 3.12 (the oldest version still in bugfix).
@jarq6c jarq6c added the enhancement New feature or request label Oct 30, 2024
@jarq6c jarq6c self-assigned this Oct 30, 2024
@jarq6c
Copy link
Collaborator Author

jarq6c commented Oct 30, 2024

I'll do each subpackage one at a time and address issues as needed.

@aaraney
Copy link
Member

aaraney commented Oct 30, 2024 •
edited
Loading

Agreed! We should use this opportunity to move package metadata fully to pyproject.toml also.

edit: fixed in #263

This was referenced Nov 19, 2024
Merged
Closed
Merged
@jarq6c
Copy link
Collaborator Author

jarq6c commented Nov 20, 2024

Leaving this open until we get to .github/workflows/run_slow_unit_tests.yml

aaraney added a commit to aaraney/hydrotools that referenced this issue Nov 20, 2024
@aaraney
ci: run slow unit tests on 3.11 & 3.12 (closes NOAA-OWP#259)
93700f6
@aaraney aaraney mentioned this issue Nov 20, 2024
Merged
@jarq6c jarq6c closed this as completed in 3b7d9b0 Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jarq6c jarq6c

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: run slow unit tests on 3.11 & 3.12 aaraney/hydrotools
2 participants
@jarq6c @aaraney