Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gsl/develop from develop 2021/05/31 #83

Conversation

climbfuji
Copy link

@climbfuji climbfuji commented May 31, 2021

Description

Update gsl/develop from develop 2021/05/31. Changes:

  • Add import/export fields for fv3-jedi coupling
  • Add p7a test using tiled FV3 Fix files, P7a ICs and NoahMP; add open-water normalization in CMEPS
  • Update CDEPS submodule and CDEPS tests
  • Updates to regression tests due to the changes in fv3atm and ccpp-physics (see associated PRs)
  • Bug fixes for coupled model for GNU
  • Bug fixes for 35-day runs
  • Update for CI tests

Additional changes made in this PR:

  • Reduce time step of all fv3_gsd* regression tests from 600s to 450s to address instability/reproducibility issues
  • Remove duplicate entries from tests/default_vars.sh
  • Remove lssav from tests/parm/gsd.nml.IN
  • Increase wallclock time for test fv3_gsd_noah_mynnsfc from 30 to 45min (required for GNU)

Associated PRs:
NOAA-GSL/ccpp-framework#15
NOAA-GSL/ccpp-physics#93
NOAA-GSL/fv3atm#93
#83

Regression testing

Regression testing on hera.{gnu,intel} against existing baselines. All regression tests pass except the following, as expected due to missing baselines or changes to the answers (due to the shorter integration time step of 450s). All three tests run to completion.

fv3_gsd
fv3_gsd_debug
fv3_gsd_dtend_debug

rt_hera_intel_verify_against_existing.log
rt_hera_intel_verify_against_existing_fail_test.log
rt_hera_gnu_verify_against_existing.log
rt_hera_gnu_verify_against_existing_fail_test.log

Regression testing on hera.{intel,gnu} using rt_ccpp_dev.conf: first create temporary baseline, then verify against it (tests for completion of runs, run-to-run reproducibility, restart reproducibility and GSL dragsuite vs UGWPv1 dragsuite reproducibility): all tests pass.

rt_ccpp_dev_hera_gnu_create.log
rt_ccpp_dev_hera_gnu_verify.log
rt_ccpp_dev_hera_intel_create.log
rt_ccpp_dev_hera_intel_verify.log

These PRs are ready for merging.

DusanJovic-NOAA and others added 5 commits May 21, 2021 15:12
* Add import and export fields to support fv3-jedi coupling
* fd_nems.yaml file is updated to include fields used in fv3-jedi coupling. It is actual file now, not a symlink to a file in CMEPS repo.
…water normalization in CMEPS (ufs-community#549) (ufs-community#585)


* add default variables for v16 non-tiled inputs
* add script for tiled fix input
* add new v16 noahmp test to rt.conf
* remove satemdf suite from s2sw compile (unused)
* add gaea.intel to rt_35d.conf
* add landice variable
* add landice setting to benchmark_v16 nml
* set landice true for non-noahmp
* set landice=false for v16 noahmp tests
* add aofrac_normalization
* commit removal of fd_nems from correct branch
* Point CDEPS to develop branch of NOAA-EMC/CDEPS
* Change application name "DATM" to "NG-GODAS"
* Change application name "DATM-NEMS" to "NG-GODAS-NEMSDATM"
* Use a mesh file in MOM6 cap instead of a grid file
… consistent (ufs-community#529)

Substantial changes to CCPP physics to move surface emissivity/albedo calculation to its own scheme and to make
surface roughness length composite consistent when fractional landmask is used. Updates to FV3GFS_io.F90 to write
additional fields to the restart files (this requires removing the UGWPv1 warmstart test).

Additional changes:

Bug fixes for coupled model for GNU from @DeniseWorthen
Bug fixes for 35-day runs from @DeniseWorthen
Update for CI tests from @MinsukJi-NOAA
junwang-noaa and others added 10 commits June 2, 2021 11:15
* Most GFSv14/GFSv15 based tests are updated to GFSv16 confiscation, the cold start ICs were created from GFSv16 anaylysis. A GDAS forecast case using IAU is also setup.
* Debug tests are added for global regression tests
* Regional tests was renamed, and regional threads was added
* History file names are changed from "phyf/dynf" to operational file names "sfcf/atmf"
* Restart files for baseline comparison are removed from the GFSv16 feature tests, only those tests with restart will still have restart files comparison
* There is no change in non-GFS configuration tests using gsd, rrtf, hafs physics package
* The first commit has no changes in cpld tests and datm tests.
* The inline post issue in post interface post_*.F90 is fixed for gnu compiler.
* amip_interp_nml namelist is removed from all the name list files
* Unused configuration varaibles: cpl, memuse_verbose, atmos_nthreads, use_hyper_thread, ncores_per_node are removed from model_configure
* The issue with inline post restart with gnu compiler is fixed
* Input data directory input-data-20210528 has new 172 leves 2021032206 ICs for C96, C192 and C384 global input files.
* utest related changes

Co-authored-by: denise.worthen <[email protected]>
Co-authored-by: MinsukJi-NOAA <[email protected]>
Co-authored-by: junwang-noaa <[email protected]>
…_dev.conf after GFS v16 global regression test changes
* Update utest script: Handle global, regional, and coupled tests
* Update CI workflow: Instead of saving the docker image (~730 MB) as an artifact, only save the executable (~77 MB)
* Add regional thread and decomposition tests to CI
* Add coupled restart test to CI
* Fix to run threads on its own core in ec2 for thread tests
* Use a slightly different ubuntu-hpc image to match the uid and gid within ec2 instances
* Exclude L127 control test temporarily
@climbfuji climbfuji marked this pull request as ready for review June 7, 2021 13:50
Copy link

@DomHeinzeller DomHeinzeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note. All code changes are coming from the authoritative repository and have been reviewed by the appropriate code owners when they were merged into develop. Regression testing completed.

@SamuelTrahanNOAA SamuelTrahanNOAA merged commit fc28751 into NOAA-GSL:gsl/develop Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants