Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gsl/develop from main 2021/05/31 #93

Conversation

climbfuji
Copy link

@climbfuji climbfuji commented May 31, 2021

Update gsl/develop from main 2021/05/31 and bug fix for tendencies code in drag_suite.F90. Changes:

  • consistent calculation of surface roughness length with fractional landmask
  • update of surface emissivity/albedo calculation for Noah, NoahMP and RUC LSM
    • new scheme GFS_radiation_surface, independent of RRTMG/RRTMGP choice
  • consistency checks between namelist options and suite definition file
  • RUC LSM update
  • bug fixes in several schemes (inconsistencies between CCPP metadata and Fortran code)
  • bug fix in drag_suite.F90: add missing initialization of udtend, vdtend, Tdtend if ldiag3d is false

Associated PRs:
NOAA-GSL/ccpp-framework#15
#93
NOAA-GSL/fv3atm#93
NOAA-GSL/ufs-weather-model#83

For regression testing, see NOAA-GSL/ufs-weather-model#83.

tanyasmirnova and others added 30 commits March 26, 2021 19:45
…emes into GFS_radiation_surface, consolidate, fix bugs
lsm_ruc_init. This is needed for MYNN surface layer scheme at the first
time step.
…composites_post, add necessary new interstitial variables, clean up old/unused interstitial variables
…ve_sfc_emis_alb_calculation_to_its_own_scheme_and_z0_composite_consistent
…composite_consistent_sfcqv_init' of https://github.com/tanyasmirnova/ccpp-physics into move_sfc_emis_alb_calculation_to_its_own_scheme_and_z0_composite_consistent
…een original ialbflg==1/iemslw==1 code and new code
…n_to_its_own_scheme_and_z0_composite_consistent_tanya_21apr21

Small bug fixes and changes in comments in setalb for ialb=1 or 2.
Changes necessary to remove GSD_SURFACE_FLUXES_BUGFIX from ccpp-physics
climbfuji and others added 16 commits May 18, 2021 13:00
…_sfc_emis_alb_calculation_to_its_own_scheme_and_z0_composite_consistent
…composite_consistent' into move_sfc_emis_alb_calculation_to_its_own_scheme_and_z0_composite_consistent_gjf
…o_its_own_scheme_and_z0_composite_consistent_gjf

Copy FV3 changes in GFS_phys_time_vary.fv3.F90/meta to SCM versions
Ensure consistency between model namelist and CCPP suite definition file UPDATED with head of MAIN
…on_to_its_own_scheme_and_z0_composite_consistent_tgs

Removed SNET.
…_sfc_emis_alb_calculation_to_its_own_scheme_and_z0_composite_consistent
…t, _timestep_init, _timestep_final, _final routines; use horizontal_loop_extent in _run routines
…ion_to_its_own_scheme_and_z0_composite_consistent

Move sfc emis alb calculation to its own scheme and z0 composite consistent
@climbfuji climbfuji marked this pull request as ready for review June 7, 2021 13:50
Copy link

@DomHeinzeller DomHeinzeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All code changes (except bug fixes related to the new tendency code) are coming from the authoritative repository and have been reviewed by the appropriate code owners when they were merged into main. Regression testing completed.

@SamuelTrahanNOAA SamuelTrahanNOAA merged commit 40ad71e into NOAA-GSL:gsl/develop Jun 7, 2021
@climbfuji climbfuji deleted the update_gsl_develop_from_main_20210531 branch June 27, 2022 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants