Update global GFS regression tests #561

junwang-noaa · 2021-05-07T01:39:45Z

PR Checklist

Ths PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.
This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR
An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
are specified below.
If new or updated input data is required by this PR, it is clearly stated in the text of the PR.

Instructions: All subsequent sections of text should be filled in as appropriate.

The information provided below allows the code managers to understand the changes relevant to this PR, whether those changes are in the ufs-weather-model repository or in a subcomponent repository. Ufs-weather-model code managers will use the information provided to add any applicable labels, assign reviewers and place it in the Commit Queue. Once the PR is in the Commit Queue, it is the PR owner's responsiblity to keep the PR up-to-date with the develop branch of ufs-weather-model.

Description

Provide a detailed description of what this PR does. What bug does it fix, or what feature does it add? Is a change of answers expected from this PR? Are any library updates included in this PR (modulefiles etc.)?

This is first incremental commit to update all the global tests.

Most GFSv14/GFSv15 based tests are updated to GFSv16 confiscation, the cold start ICs were created from GFSv16 anaylysis. A GDAS forecast case using IAU is also setup.
Debug tests are added for global regression tests
History file names are changed from "phyf/dynf" to operational file names "sfcf/atmf"
Restart files for baseline comparison are removed from the GFSv16 feature tests, only those tests with restart will still have restart files comparison
There is no change in non-GFS configuration tests using gsd, rrtf, hafs physics package
The first commit has no changes in cpld tests and datm tests.
The inline post issue in post interface post_*.F90 is fixed for gnu compiler.
amip_interp_nml namelist is removed from all the name list files
Unused configuration varaibles: cpl, memuse_verbose, atmos_nthreads, use_hyper_thread, ncores_per_node are removed from model_configure
Input data directory input-data-20210528 has new 172 leves 2021032206 ICs for C96, C192 and C384 global input files.

This PR requires new input files for the GFSv16 tests.

Issue(s) addressed

Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues must always be created before starting work on a PR branch!)

fixes issues:
#143
#528
#487

Testing

How were these changes tested? What compilers / HPCs was it tested with? Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) Have regression tests and unit tests (utests) been run? On which platforms and with which compilers? (Note that unit tests can only be run on tier-1 platforms)

Dependencies

If testing this branch requires non-default branches in other repositories, list them. Those branches should have matching names (ideally).

fv3atm PR #321

DusanJovic-NOAA · 2021-05-07T19:44:14Z

tests/parm/control_csawmg.nml.IN

@@ -0,0 +1,303 @@
+&amip_interp_nml


this namelist is not used. can be removed from all input.nml namelist templates

@bensonr May I ask if the namelist amip_interp_nml variables are actually used in the FV3GFS runs?

To my knowledge, this nml is unused.

amip_interp is a deprecated method for providing amip datasets. It has been long superseded by the data_override capabilities which is much more powerful and used directly in many GFDL components and the FMS Coupling system. Please feel free to remove the nml references where needed.

Rusty, thanks for the explanation. The amip_interp_nml is removed in the updated global tests.

Shouldn't amip_interp_nml be removed from all input_nml templates, not just global?

yangfanglin · 2021-05-10T20:54:19Z

Rusty,
I'd suggest we keep it in case developers want to run AMIP-type experiments, although I do not know if this is specifically set up for AMIP experiments. Has GFDL ever used this option ?

DeniseWorthen · 2021-06-01T17:47:25Z

OK, thanks. Should I re-run the gnu tests now that you've removed it from rt.conf? I will need to do some digging to resolve the CMEPS/gnu failure so that will take time.

junwang-noaa · 2021-06-01T17:55:48Z

Yes, please add a note on the cheyenne gnu log file and commit the log file as is. Thanks

…

On Tue, Jun 1, 2021 at 1:47 PM Denise Worthen ***@***.***> wrote: OK, thanks. Do you want me to commit the cheyenne gnu log as is? If so, I will add a message about the failed gnu cpld test. I agree this will require digging into the CMEPS code and should be made a separate issue. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#561 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AI7D6TJMXF6FPTMGDQDV3ULTQUML3ANCNFSM44IJPLPA> .

* cpld tests should have been removed from rt.conf since testing on hera indicated they would fail. The failure is is in the Imp and Exp Accum counts in the mediator restart file. All other fields in the mediator restart file are identical.

…model into gfs_rt

*repeated test cpld_bmarkfrac_wave_v16_noahmp passed *no error in the log or run directory to explain the failed test the first time.

climbfuji

A few comments, but nothing that should hold back the PR.

If I see this correctly, any remaining tests in tests/tests starting with fv3_ I will need to work on in a follow-up PR?

climbfuji · 2021-06-01T18:59:44Z

tests/rt_gnu.conf


-COMPILE | APP=ATM SUITES=FV3_GFS_2017_fv3wam 32BIT=Y MULTI_GASES=Y DEBUG=Y                                                        |                | fv3         |
-RUN     | fv3_multigases_debug                                                                                                    |                | fv3         |
+#COMPILE | APP=ATM SUITES=FV3_GFS_2017_fv3wam 32BIT=Y MULTI_GASES=Y DEBUG=Y                                                        |                | fv3         |


I just added this test, why is it commented out again?

Because the multigases test requires FV3_GFS_2017_fv3wam suite file, which was not used in the new RT test suite any more. The fv3_multigases test was commented out. Henry/Kate is preparing a PR to update multigases test using new ICs from GFSv16 analysis file, they can update the fv3_multigases_debug test in their PR. This way we can get rid of the old GFSv14 ICs.

climbfuji · 2021-06-01T19:02:00Z

tests/tests/control_csawmgt

@@ -0,0 +1,40 @@
+###############################################################################
+#
+#  Global control csawmgt test


I am a little confused what the "control" stands for in all these tests. I thought control is GFS v16, and any suffix describes deviations from GFS v16 control (e.g. _flake, _2threads). But csawmg is an entirely different suite, for example.

Yes, the control test is GFS_v16. Any suffix test has new updates from GFS_v16, it could be additional new features or new physics packages replacing current one used in opn GFS v16. In the case of csawmgt, the setting is based in L127 GFS_v16 test, only the related physics namelist are changed, the same for control_noahmp, control_rrtmgp, control_thompson, etc.

junwang-noaa · 2021-06-01T19:26:05Z

A few comments, but nothing that should hold back the PR.

If I see this correctly, any remaining tests in tests/tests starting with fv3_ I will need to work on in a follow-up PR?

Bin Liu is updating the fv3_stretch tests, Henry/Kate on fv3_multigases. I think you will need to update other global tests including fv3_gsd, fv3_hafs and fv3_rrfs etc.

utest changes to go with gfs_rt updates

…t out control_c384 tests due to reserved node limit on cray

…model into gfs_rt

…ity#561) * update upp, ccpp/physics and cmakelist to use w3emc 2.9.2

junwang-noaa added 23 commits March 18, 2021 19:39

update test script to run GFSv16 control and related tests

eb5728e

update the history file names

41c11a8

merge to develop branch

d68a249

remove old tests

6ca70a5

update gfsv16 test names

230b2ad

update history file names

52cc297

add debug test and fixes for RRTMGP tests

6bfbc57

update csawmg test

daa7e50

update to top of develop branch

026c6b8

update csawmg based on control tests

3aeef2a

updates for ugwpv1, merra2 and flake

ca4b365

add several debug tests

eba6c59

merge to develop branch

625078f

update to new ICs

8a0ff8f

fix gfsv16_noahmp test

15c8045

add control_noahmp_debug

94f0686

add FV3_GFS_v16_fv3wam for compile jobs

d9e791f

add gdas test and update debug tests

ea21e4a

fix regional tests

4b97ede

update phyf/dynf to sfcf/atmf

3ba51f7

change phy/dyn to sfc/atm for coupled tests

45d8480

update rt.conf

e48397c

merge to the develop branch

f2b1fa6

junwang-noaa changed the title ~~Gfs rt~~ Update global GFS regression tests May 7, 2021

comment out fv3 wave test

e4ef9e5

DusanJovic-NOAA reviewed May 7, 2021

View reviewed changes

junwang-noaa added 3 commits May 7, 2021 20:14

remove restart files from feature tests

039b0cc

update lndp_var namelist

7c1fb58

turn off control_rrtmgp_2threads control_rrtmgp_c192

0a3e17e

DeniseWorthen and others added 3 commits June 1, 2021 11:58

add cheyenne-gnu log with failed cpld tests

63231a6

* cpld tests should have been removed from rt.conf since testing on hera indicated they would fail. The failure is is in the Imp and Exp Accum counts in the mediator restart file. All other fields in the mediator restart file are identical.

rewrite inlinepost post for gnu

5960a47

Merge branch 'gfs_rt' of https://github.com/junwang-noaa/ufs-weather-…

6b1f323

…model into gfs_rt

junwang-noaa requested review from DusanJovic-NOAA and climbfuji June 1, 2021 18:34

DeniseWorthen and others added 3 commits June 1, 2021 12:41

add cheyenne.intel log

825de46

*repeated test cpld_bmarkfrac_wave_v16_noahmp passed *no error in the log or run directory to explain the failed test the first time.

Add utest related changes

c243ab9

Merge remote-tracking branch 'origin/gfs_rt' into gfs_rt

be08fb1

climbfuji approved these changes Jun 1, 2021

View reviewed changes

Merge pull request #12 from MinsukJi-NOAA/gfs_rt

a5ca562

utest changes to go with gfs_rt updates

DusanJovic-NOAA approved these changes Jun 1, 2021

View reviewed changes

junwang-noaa and others added 10 commits June 1, 2021 19:44

change ECF_TRIES back to 1

8919e3a

add cheyenne.gnu log

0e7fb7b

add cheyenne.intel log

a630253

commit log file from gaea/hera/dell, fix thread debug test and commen…

396b447

…t out control_c384 tests due to reserved node limit on cray

Merge branch 'gfs_rt' of https://github.com/junwang-noaa/ufs-weather-…

9fe108e

…model into gfs_rt

update hera.intel log file

27a76cc

update orion log file

beb5813

update jet log file

77e1fbe

update rt.conf and log file on cray

0f4bd29

point fv3 back to emc repo

a1b1c86

junwang-noaa merged commit b474679 into ufs-community:develop Jun 2, 2021

junwang-noaa mentioned this pull request Jun 21, 2021

Runtime files in the wrong directory in Regression tests. #487

Closed

junwang-noaa deleted the gfs_rt branch November 24, 2021 14:51

junwang-noaa mentioned this pull request Dec 7, 2021

Add GP ORTs #946

Merged

16 tasks

pjpegion pushed a commit to NOAA-PSL/ufs-weather-model that referenced this pull request Apr 4, 2023

update upp, ccpp/physics and cmakelist to use w3emc 2.9.2 (ufs-commun…

2b23cd1

…ity#561) * update upp, ccpp/physics and cmakelist to use w3emc 2.9.2

mkavulich mentioned this pull request Oct 14, 2024

SRW forecast runs do not use threading even if OMP_NUM_THREADS_RUN_FCST is set > 1 ufs-community/ufs-srweather-app#1138

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update global GFS regression tests #561

Update global GFS regression tests #561

junwang-noaa commented May 7, 2021 •

edited

Loading

DusanJovic-NOAA May 7, 2021

junwang-noaa May 10, 2021

bensonr May 10, 2021

bensonr May 11, 2021

junwang-noaa May 11, 2021

DusanJovic-NOAA May 27, 2021

yangfanglin commented May 10, 2021

DeniseWorthen commented Jun 1, 2021 •

edited

Loading

junwang-noaa commented Jun 1, 2021 via email

climbfuji left a comment

climbfuji Jun 1, 2021

junwang-noaa Jun 1, 2021

climbfuji Jun 1, 2021

junwang-noaa Jun 1, 2021

junwang-noaa commented Jun 1, 2021

Update global GFS regression tests #561

Update global GFS regression tests #561

Conversation

junwang-noaa commented May 7, 2021 • edited Loading

PR Checklist

Instructions: All subsequent sections of text should be filled in as appropriate.

Description

Issue(s) addressed

Testing

Dependencies

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yangfanglin commented May 10, 2021

DeniseWorthen commented Jun 1, 2021 • edited Loading

junwang-noaa commented Jun 1, 2021 via email

climbfuji left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

junwang-noaa commented Jun 1, 2021

junwang-noaa commented May 7, 2021 •

edited

Loading

DeniseWorthen commented Jun 1, 2021 •

edited

Loading