Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix default storage class #7

Merged
merged 2 commits into from
Mar 22, 2019
Merged

Fix default storage class #7

merged 2 commits into from
Mar 22, 2019

Conversation

jonandernovella
Copy link
Collaborator

@jonandernovella jonandernovella commented Mar 22, 2019 •
edited
Loading

This PR fixes the cinder default storage class. Solves #6 .

nanjiangshu
nanjiangshu reviewed Mar 22, 2019
View reviewed changes
Copy link

@nanjiangshu nanjiangshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Jon,

The PR looks fine to me. However, I'm a bit unclear about the benefit of the new code. It seems you are also using cinder in the previous code.

/Nanjiang

@jonandernovella
Copy link
Collaborator Author

Hi Jon,

The PR looks fine to me. However, I'm a bit unclear about the benefit of the new code. It seems you are also using cinder in the previous code.

/Nanjiang

Take a look at issue #6, as I described in the PR.

/Jon

@jonandernovella jonandernovella mentioned this pull request Mar 22, 2019
Closed
@jonandernovella jonandernovella merged commit 8bfa653 into master Mar 22, 2019
@jonandernovella jonandernovella deleted the dev/fix_sc branch June 10, 2019 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nanjiangshu nanjiangshu nanjiangshu left review comments

@jbygdell jbygdell jbygdell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonandernovella @nanjiangshu @jbygdell