Zoom in AOI when analysis is run #906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for veda-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Looking good so far @hanbyul-here ! 👍 |
hanbyul-here
force-pushed
the
857/aoi-toi-zoom
branch
from
5b614f1 to
edc3c25
Compare
Merged
faustoperez
approved these changes
Apr 1, 2024
**Related Ticket:** #857 ### Description of Changes Zoom TOI when analysis is run ### Notes & Questions About Changes Focus on TOI when analysis is run. I meant to separate this PR from #906, but it was faster to use the structure already set up in #906 to trigger callback when analysis is run, so this PR builds on top of #906. This is WIP, but I wanted to run how it behaves with team members.
sandrahoang686
approved these changes
Apr 2, 2024
hanbyul-here
added a commit
that referenced
this pull request
May 1, 2024
## 🎉 Features - Zoom in AOI, TOI when analysis is run in #906 - Add custom javascript injection #846 - ADR for V2 Refactor: #875 - Open all external links in a new tab in #870 - Include dataset id to filter layers in #910 - Some datasets can only be analyzed with layers from the same source in #913 - Create minimal partial data layer scaffold starting off with Data Catalog for VEDA2 Refactor in #893 - Add analysis preset in #921 ## 🚀 Improvements - Chart style improvement in #903 - Data Catalog enhancement with floating filter sidebar in #918 - Sum as statistics option in #925 - ## 🐛 Fixes - Sort featured stories based on publication date in descending order in #907 - Replace latency with temporalResolution in layer info in #898 - Add a workaround for Safari scroll problem in #909 - Handle empty result in #922
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Ticket: #857
Description of Changes
Zoom aoi when analysis gets run (note that this PR only handles AOI, not TOI)
Notes & Questions About Changes
Mapbox has fitBonds problem with some projections: mapbox/mapbox-gl-js#12565 Because of this issue, we have to do manual centering which might not look very smooth.
Validation / Testing
Run Analysis on this page:
https://deploy-preview-906--veda-ui.netlify.app/exploration?datasets=%5B%7B%22id%22%3A%22casa-gfed-co2-flux-fuel%22%2C%22settings%22%3A%7B%22isVisible%22%3Atrue%2C%22opacity%22%3A100%2C%22analysisMetrics%22%3A%5B%7B%22id%22%3A%22min%22%2C%22label%22%3A%22Min%22%2C%22chartLabel%22%3A%22Min%22%2C%22themeColor%22%3A%22infographicA%22%7D%2C%7B%22id%22%3A%22mean%22%2C%22label%22%3A%22Average%22%2C%22chartLabel%22%3A%22Avg%22%2C%22themeColor%22%3A%22infographicB%22%7D%2C%7B%22id%22%3A%22max%22%2C%22label%22%3A%22Max%22%2C%22chartLabel%22%3A%22Max%22%2C%22themeColor%22%3A%22infographicC%22%7D%2C%7B%22id%22%3A%22std%22%2C%22label%22%3A%22St+Deviation%22%2C%22chartLabel%22%3A%22STD%22%2C%22themeColor%22%3A%22infographicD%22%7D%2C%7B%22id%22%3A%22median%22%2C%22label%22%3A%22Median%22%2C%22chartLabel%22%3A%22Median%22%2C%22themeColor%22%3A%22infographicE%22%7D%5D%7D%7D%5D&date=2017-11-30T15%3A00%3A00.000Z&aois=%5B%22kpoaX%7BdjwCozrlC%3F%3FnwdmFpnkuDzs_N%22%2C%22ef9c32%22%2Ctrue%5D&dateRange=2017-09-30T15%3A00%3A00.000Z%7C2017-12-31T15%3A00%3A00.000Z