Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TOI zoom behavior #908

Merged
merged 5 commits into from
Apr 2, 2024
Merged

Add TOI zoom behavior #908

merged 5 commits into from
Apr 2, 2024

Conversation

hanbyul-here
Copy link
Collaborator

@hanbyul-here hanbyul-here commented Mar 31, 2024

Related Ticket: #857

Description of Changes

Zoom TOI when analysis is run

Notes & Questions About Changes

Focus on TOI when analysis is run. I meant to separate this PR from #906, but it was faster to use the structure already set up in #906 to trigger callback when analysis is run, so this PR builds on top of #906.
This is WIP, but I wanted to run how it behaves with team members.

One problem I would like to raise: 'Current' timeline head works as a central point of Zoom. When I want to adjust the zoom level after the automatic zoom, I lose the chart view very easily unless my 'Current' timeline head happens to be at the center of the selected interval.

Validation / Testing

Run analysis on : https://deploy-preview-908--veda-ui.netlify.app/exploration?datasets=%5B%7B%22id%22%3A%22no2-monthly-2%22%2C%22settings%22%3A%7B%22isVisible%22%3Atrue%2C%22opacity%22%3A100%2C%22analysisMetrics%22%3A%5B%7B%22id%22%3A%22min%22%2C%22label%22%3A%22Min%22%2C%22chartLabel%22%3A%22Min%22%2C%22themeColor%22%3A%22infographicA%22%7D%2C%7B%22id%22%3A%22mean%22%2C%22label%22%3A%22Average%22%2C%22chartLabel%22%3A%22Avg%22%2C%22themeColor%22%3A%22infographicB%22%7D%2C%7B%22id%22%3A%22max%22%2C%22label%22%3A%22Max%22%2C%22chartLabel%22%3A%22Max%22%2C%22themeColor%22%3A%22infographicC%22%7D%2C%7B%22id%22%3A%22std%22%2C%22label%22%3A%22St+Deviation%22%2C%22chartLabel%22%3A%22STD%22%2C%22themeColor%22%3A%22infographicD%22%7D%2C%7B%22id%22%3A%22median%22%2C%22label%22%3A%22Median%22%2C%22chartLabel%22%3A%22Median%22%2C%22themeColor%22%3A%22infographicE%22%7D%5D%7D%7D%2C%7B%22id%22%3A%22no2-monthly-diff%22%2C%22settings%22%3A%7B%22isVisible%22%3Atrue%2C%22opacity%22%3A100%2C%22analysisMetrics%22%3A%5B%7B%22id%22%3A%22min%22%2C%22label%22%3A%22Min%22%2C%22chartLabel%22%3A%22Min%22%2C%22themeColor%22%3A%22infographicA%22%7D%2C%7B%22id%22%3A%22mean%22%2C%22label%22%3A%22Average%22%2C%22chartLabel%22%3A%22Avg%22%2C%22themeColor%22%3A%22infographicB%22%7D%2C%7B%22id%22%3A%22max%22%2C%22label%22%3A%22Max%22%2C%22chartLabel%22%3A%22Max%22%2C%22themeColor%22%3A%22infographicC%22%7D%2C%7B%22id%22%3A%22std%22%2C%22label%22%3A%22St+Deviation%22%2C%22chartLabel%22%3A%22STD%22%2C%22themeColor%22%3A%22infographicD%22%7D%2C%7B%22id%22%3A%22median%22%2C%22label%22%3A%22Median%22%2C%22chartLabel%22%3A%22Median%22%2C%22themeColor%22%3A%22infographicE%22%7D%5D%7D%7D%5D&date=2023-08-31T15%3A00%3A00.000Z&aois=%5B%22ti%7BoImcpzCgvxsGc%7CoJnihClgo%7BDtv%7CfGfpba%40%22%2C%2241255a%22%2Ctrue%5D&dateRange=2023-06-30T15%3A00%3A00.000Z%7C2023-09-30T15%3A00%3A00.000Z

Copy link

netlify bot commented Mar 31, 2024

Deploy Preview for veda-ui ready!

Name Link
🔨 Latest commit 6f0eda2
🔍 Latest deploy log https://app.netlify.com/sites/veda-ui/deploys/660c0b454411eb0008247f73
😎 Deploy Preview https://deploy-preview-908--veda-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@faustoperez faustoperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this works better than having a tiny analysis slice at the end of the timeline 👍

@hanbyul-here hanbyul-here changed the title Add TOI zoom behavior for testing Add TOI zoom behavior Apr 2, 2024
@hanbyul-here hanbyul-here marked this pull request as ready for review April 2, 2024 09:13
Copy link
Collaborator

@sandrahoang686 sandrahoang686 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic lgtm! small comment about commented out code otherwise :shipit:

@hanbyul-here hanbyul-here merged commit 86bcb09 into 857/aoi-toi-zoom Apr 2, 2024
8 checks passed
@hanbyul-here hanbyul-here deleted the 857/toi-poc branch April 2, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants