Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace latency with temporalResolution in layer info #898

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

j08lue
Copy link
Contributor

@j08lue j08lue commented Mar 21, 2024

Related Ticket:

Closes #897

Description of Changes

Temporal resolution (data periodicity) is more relevant to show in the short layer info than latency (data publication frequency).

This PR swaps the two in the LayerInfo object and updates the docs.

Validation / Testing

Check out the Exploration and Analysis interface (/exploration) and see the temporalResolution information on the layer cards as well as in the header of the layer info modal.

@j08lue j08lue requested a review from hanbyul-here March 21, 2024 16:37
Copy link

netlify bot commented Mar 21, 2024

Deploy Preview for veda-ui ready!

Name Link
🔨 Latest commit aaf2450
🔍 Latest deploy log https://app.netlify.com/sites/veda-ui/deploys/65fc6252ae039b00082f4686
😎 Deploy Preview https://deploy-preview-898--veda-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@j08lue j08lue requested a review from sandrahoang686 March 23, 2024 08:01
@hanbyul-here hanbyul-here merged commit 5d2e318 into main Mar 25, 2024
8 checks passed
@hanbyul-here hanbyul-here deleted the fix/layerinfo-correction branch March 25, 2024 22:15
hanbyul-here added a commit that referenced this pull request May 1, 2024
## 🎉 Features
- Zoom in AOI, TOI when analysis is run in
#906
- Add custom javascript injection
#846
- ADR for V2 Refactor: #875
- Open all external links in a new tab in
#870
- Include dataset id to filter layers in
#910
- Some datasets can only be analyzed with layers from the same source in
#913
- Create minimal partial data layer scaffold starting off with Data
Catalog for VEDA2 Refactor in
#893
- Add analysis preset in #921

## 🚀 Improvements
- Chart style improvement in
#903
- Data Catalog enhancement with floating filter sidebar in
#918
- Sum as statistics option in
#925
-
## 🐛 Fixes
- Sort featured stories based on publication date in descending order in
#907
- Replace latency with temporalResolution in layer info in
#898
- Add a workaround for Safari scroll problem in
#909
- Handle empty result in #922
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[E & A] Use temporal resolution instead of latency in layer info
3 participants