Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mobile secondary nav bug #3049

Merged
merged 4 commits into from
Apr 23, 2019
Merged

Conversation

@cadecairos cadecairos temporarily deployed to foundation-mofostaging-pr-3049 April 22, 2019 23:25 Inactive
@mmmavis mmmavis requested review from beccaklam and Pomax April 23, 2019 00:30
@mmmavis mmmavis removed request for Pomax and beccaklam April 23, 2019 00:49
@mmmavis mmmavis temporarily deployed to foundation-mofostaging-pr-3049 April 23, 2019 00:55 Inactive
@mmmavis mmmavis temporarily deployed to foundation-mofostaging-pr-3049 April 23, 2019 00:58 Inactive
Copy link

@beccaklam beccaklam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 👍

@mmmavis mmmavis merged commit 060d594 into master Apr 23, 2019
@mmmavis
Copy link
Collaborator Author

mmmavis commented Apr 23, 2019

🎉

@mmmavis mmmavis deleted the issue-3047-mobile-secondary-nav-bug branch April 24, 2019 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Secondary nav on mobile should only appear when there are nav items to show
4 participants