Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secondary nav on mobile should only appear when there are nav items to show #3047

Closed
mmmavis opened this issue Apr 22, 2019 · 0 comments · Fixed by #3049
Closed

Secondary nav on mobile should only appear when there are nav items to show #3047

mmmavis opened this issue Apr 22, 2019 · 0 comments · Fixed by #3049

Comments

@mmmavis
Copy link
Collaborator

mmmavis commented Apr 22, 2019

Describe the bug

On mobile, secondary nav dropdown box is always there even when there's no nav item to show (the empty dropdown gets collapsed into a thick grey line).

To Reproduce

Steps to reproduce the behavior:

  1. On mobile screen size, go to any primary / opportunity / campaign page that doesn't have child pages
  2. Notice the thick grey line around header section.

Expected behavior

Empty dropdown / grey line shouldn't be there.

Screenshots

From https://foundation.mozilla.org/en/internet-health/

From https://foundation.mozilla.org/en/campaigns/equifax-breach/

/cc @beccaklam @kristinashu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant