Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'Line' to Primary/Bannered Campaign Pages with no sub-nav #3045

Closed
beccaklam opened this issue Apr 22, 2019 · 4 comments
Closed

Add 'Line' to Primary/Bannered Campaign Pages with no sub-nav #3045

beccaklam opened this issue Apr 22, 2019 · 4 comments
Assignees
Labels

Comments

@beccaklam
Copy link

beccaklam commented Apr 22, 2019

We want to add a line for a visual break/centering purposes on both full width and narrow templates of the Primary/Bannered Campaign pages with no sub nav. Currently it looks a bit awkward without it.

Related tickets: #3022
Redpen is here: https://redpen.io/p/ys4594fedace293c98

Current:

Screen Shot 2019-04-22 at 11 57 33 AM

Screen Shot 2019-04-22 at 11 57 25 AM

Mobile:

Spacing is 24px above and below line
Screen Shot 2019-04-22 at 11 55 22 AM

Tablet:

Spacing is 48px above and below line
Screen Shot 2019-04-22 at 11 55 52 AM

Desktop:

Spacing is 48px above and below the line
Screen Shot 2019-04-22 at 11 56 22 AM


@mmmavis mmmavis self-assigned this Apr 22, 2019
@mmmavis
Copy link
Collaborator

mmmavis commented Apr 23, 2019

Blocked by PR #3025 #3049

@mmmavis
Copy link
Collaborator

mmmavis commented Apr 23, 2019

We want to add a line for a visual break/to help the user center text on a narrow template on Primary/Bannered Campaign pages with no sub nav. Currently it looks a bit awkward without it.

@beccaklam since the gap in between the heading section and main content is kinda huge, I'm wondering if we should add divider line to both wide & narrow templates?

@beccaklam
Copy link
Author

@mmmavis yes we want the line on both wide and narrow templates. Sorry just reworded my ask!

@mmmavis
Copy link
Collaborator

mmmavis commented Apr 24, 2019

Fixed as part of PR #3025.

@mmmavis mmmavis closed this as completed Apr 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants