Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(zk): add zksolc support #45

Merged
merged 11 commits into from
Nov 26, 2024
Merged

feat(zk): add zksolc support #45

merged 11 commits into from
Nov 26, 2024

Conversation

Karrq
Copy link

@Karrq Karrq commented Nov 26, 2024

Update foundry-compilres to 0.12.3 taking latest changes from 0.11.6 (up to 87c2e83).

New features compared to 0.11.6:

  • settings restrictions (to be implemented, currently stubbed out)
  • compilation profiles & per-file compilation settings

elfedy and others added 8 commits November 25, 2024 21:44
@elfedy @Karrq
feat: add zksolc support
312b12b
@tomimor @Karrq
fix: codeowner change (#32,#34)
629a55c
@Karrq
feat: zksolc v1.5.7 support (#35)
c9cd4cb 
* feat: zksolc 1.5.7 support

* chore: update version constants
@slowli @Karrq
feat: Support error / warning suppression in zksolc (#33)
9eb75e6 
feat: add FromStr to ZkSolcWarnings and ZkSolcErrors (#37)
@dutterbutter @Karrq
fix: add back skip filter over avoid-contracts
02e8404
@Karrq
feat(zk): properly mark unlinked contract (#40,#41,#43,#44)
87c2e83 
feat(zk): mark bytecode as unlinked
refactor(zk): get output from `eravm` object
feat: retain pre-1.5.7 zksolc compatibility
test(artifact:zk): unprefixed bytecode test
@Karrq
chore: bump version
61734b2
@Karrq
chore: merge conflicts 11.6->12.3
89f0b2b 
feat(zk): per-source profile & settings
feat(zk): stub our zksolc settings restrictions
@Karrq Karrq self-assigned this Nov 26, 2024
@Karrq Karrq merged commit c0cc4bc into zksync-v0.12.3 Nov 26, 2024
4 checks passed
@Karrq Karrq deleted the wip-zksync-v0.12.3 branch November 26, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elfedy elfedy elfedy approved these changes

@nbaztec nbaztec Awaiting requested review from nbaztec nbaztec is a code owner

@dutterbutter dutterbutter Awaiting requested review from dutterbutter dutterbutter is a code owner

@hedgar2017 hedgar2017 Awaiting requested review from hedgar2017 hedgar2017 is a code owner

@Jrigada Jrigada Awaiting requested review from Jrigada Jrigada is a code owner

Assignees

@Karrq Karrq

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Karrq @elfedy @tomimor @slowli @dutterbutter