fix(artifacts:zk): serialize byteecode without prefix #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Karrq
requested review from
nbaztec,
elfedy,
Jrigada,
dutterbutter and
hedgar2017
as code owners
nbaztec
approved these changes
Nov 25, 2024
elfedy
approved these changes
Nov 25, 2024
|
Is it worth it to add a test that deserialization is what we expect? |
hedgar2017
approved these changes
Nov 25, 2024
Added such test, tried to keep it simple |
Karrq
added a commit
that referenced
this pull request
Nov 26, 2024
Karrq
added a commit
that referenced
this pull request
Nov 26, 2024
* feat: add zksolc support * fix: codeowner change (#32,#34) * feat: zksolc v1.5.7 support (#35) * feat: zksolc 1.5.7 support * chore: update version constants * feat: Support error / warning suppression in zksolc (#33) feat: add FromStr to ZkSolcWarnings and ZkSolcErrors (#37) * fix: add back skip filter over avoid-contracts * feat(zk): properly mark unlinked contract (#40,#41,#43,#44) feat(zk): mark bytecode as unlinked refactor(zk): get output from `eravm` object feat: retain pre-1.5.7 zksolc compatibility test(artifact:zk): unprefixed bytecode test * chore: bump version * chore: merge conflicts 11.6->12.3 feat(zk): per-source profile & settings feat(zk): stub our zksolc settings restrictions * fix(ci): update rust toolchain version * fix(ci): proper rust toolchain name * chore: clippy --------- Co-authored-by: Federico Rodríguez <[email protected]> Co-authored-by: Tomi Moreno <[email protected]> Co-authored-by: Alex Ostrovski <[email protected]> Co-authored-by: Dustin Brickwood <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #35 an accidental change was introduced which serialized bytecode with the
0xprefix where before it was stripped.This PR reintroduces the stripping behavior by ensuring the serialization happens thru
alloy_primitives::hex::encodefirst