-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add FromStr to ZkSolcWarnings and ZkSolcErrors #37
Conversation
Hmm I'd opt to store this as strings actually, and pass them untypedly to the compiler. |
@Karrq I guess the place to discuss this was this previous PR and not here? @hedgar2017 your call probably on this though since we will probably end up using that common crate for |
As a user if I run However, if we expect this field to change quite a bit we can implement it as a pass-through, but that would be the anti-pattern. |
Hey @elfedy - I've moved everything including these structs to this crate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving for now for the sake of unblocking, but please start migrating to our common definitions!
feat: add FromStr to ZkSolcWarnings and ZkSolcErrors (#37)
* feat: add zksolc support * fix: codeowner change (#32,#34) * feat: zksolc v1.5.7 support (#35) * feat: zksolc 1.5.7 support * chore: update version constants * feat: Support error / warning suppression in zksolc (#33) feat: add FromStr to ZkSolcWarnings and ZkSolcErrors (#37) * fix: add back skip filter over avoid-contracts * feat(zk): properly mark unlinked contract (#40,#41,#43,#44) feat(zk): mark bytecode as unlinked refactor(zk): get output from `eravm` object feat: retain pre-1.5.7 zksolc compatibility test(artifact:zk): unprefixed bytecode test * chore: bump version * chore: merge conflicts 11.6->12.3 feat(zk): per-source profile & settings feat(zk): stub our zksolc settings restrictions * fix(ci): update rust toolchain version * fix(ci): proper rust toolchain name * chore: clippy --------- Co-authored-by: Federico Rodríguez <[email protected]> Co-authored-by: Tomi Moreno <[email protected]> Co-authored-by: Alex Ostrovski <[email protected]> Co-authored-by: Dustin Brickwood <[email protected]>
This is required to parse suppressed error/warnings from cli arguments, so users can pass for example
--zk-suppressed-warnings txorigin
while also failing when passing an invalid value (Else we need to either silently pass nothing or panic)