Frontend

[tylerIams]

This PR overhauls the front-end using MUI and resolves multiple issues.

• Resolves Add whitenoise to serve static assets #10

• Resolves Handle username collisions #12

• Resolves Add fallbacks for "American Typewriter" font-family #23

• Resolves Create fall-throughs for invalid forms #24

• Resolves Make sure to use at least bootstrap version 4 #26

• Resolves Avoid "N+1 query problem" by using "__in" instead of loops #27

Next, I plan to:

1. Write comprehensive unit-tests
2. Add teacher functionality to volunteer app (will be nearly identical)
3. Work on Add ability to send text messages #20 (if you think that's still doable in the next few weeks)

Regarding input validation in #16: I'm wondering if this still needs to be performed because the data is only gathered from the form if it exists in the database (attendance/views.py line 102), which would necessitate it being valid. Since this is the case, I think I can just handle the data is not found exception? This issue was caused because I created the form directly in my template, rather than using forms.py (I still haven't thought of a way to create a form for this situation easily). Do you have any suggestions on how I should solve this issue?

[tylerIams]

I'm going to merge and open a new branch so we can have more manageable PRs going forward

[tylerIams]

True, I was just curious if there was a way to store it somewhere easily accessible... which I suppose would be the case if this were a reasonably sized pull request 😀.

…

On Sat, Aug 24, 2019 at 9:17 AM Bob Ippolito ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In staff/staff_views_helper.py <https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_MissionBit_MB-5FPortal_pull_35-23discussion-5Fr317366647&d=DwMCaQ&c=qgVugHHq3rzouXkEXdxBNQ&r=KpANKktvOUT8t5L4AGgt31o0sFSBGC3hL1OxI-Umyek&m=z5EVneN9Bnk-gf0nJAkr9Vg_aZ0nS_EOtueaeKZVqp4&s=LrCkNSe8Qzqq4ZEz1PmrszpsSdjxYD_zIHFRpU_PsTs&e=> : > @@ -439,13 +513,23 @@ def get_course_attendance_statistic(course_id): def get_my_announcements(request, group): classroom = get_classroom_by_django_user(request.user) - announcements = (Announcement.objects.filter(recipient_groups=Group.objects.get(name=group)) | Announcement.objects.filter(recipient_classrooms=classroom)).distinct() - announcement_distributions = AnnouncementDistribution.objects.filter(announcement__in=announcements, user_id=request.user.id, dismissed=False) + announcements = ( + Announcement.objects.filter(recipient_groups=Group.objects.get(name=group)) + | Announcement.objects.filter(recipient_classrooms=classroom) + ).distinct() The conversations on github PRs don't go away when they are closed — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_MissionBit_MB-5FPortal_pull_35-3Femail-5Fsource-3Dnotifications-26email-5Ftoken-3DAJBUYCFJDQKBBPDERUSGDQTQGFNHZA5CNFSM4IK5FOX2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCCS5BXY-23discussion-5Fr317366647&d=DwMCaQ&c=qgVugHHq3rzouXkEXdxBNQ&r=KpANKktvOUT8t5L4AGgt31o0sFSBGC3hL1OxI-Umyek&m=z5EVneN9Bnk-gf0nJAkr9Vg_aZ0nS_EOtueaeKZVqp4&s=tW8PVbC5paBaszWYRTwE5Y0GqnWHpZtNxqltiinfamI&e=>, or mute the thread <https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AJBUYCF64CB7ATOKSOW2VOTQGFNHZANCNFSM4IK5FOXQ&d=DwMCaQ&c=qgVugHHq3rzouXkEXdxBNQ&r=KpANKktvOUT8t5L4AGgt31o0sFSBGC3hL1OxI-Umyek&m=z5EVneN9Bnk-gf0nJAkr9Vg_aZ0nS_EOtueaeKZVqp4&s=Nke17iBZpAwpEAxxCxbrt7ZwUYQ2sBBCdAaKIK1GRys&e=> .

-- Best, Tyler Iams