Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add whitenoise to serve static assets #10

Closed
etrepum opened this issue Jul 3, 2019 · 4 comments · Fixed by #35
Closed

Add whitenoise to serve static assets #10

etrepum opened this issue Jul 3, 2019 · 4 comments · Fixed by #35

Comments

@etrepum
Copy link
Member

etrepum commented Jul 3, 2019

Here's some information for how we could do that (shouldn't be much different if deployed elsewhere): https://devcenter.heroku.com/articles/django-assets

This way we can have the logo, CSS, etc. all served with this project without having to go through much trouble.
@tylerIams
Copy link
Member

Resolved in 83fc8dd

@etrepum etrepum reopened this Aug 9, 2019
@etrepum
Copy link
Member Author

etrepum commented Aug 9, 2019

"resolved in" comments should be done with PR numbers so that the issue gets closed when the PR is merged

@etrepum
Copy link
Member Author

etrepum commented Aug 9, 2019

It's more common to do it the other way around, e.g. the PR that addresses this will say Resolves #10

@tylerIams
Copy link
Member

Got it and will do

@tylerIams tylerIams mentioned this issue Aug 12, 2019
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Frontend MissionBit/MB_Portal
2 participants
@etrepum @tylerIams