Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create fall-throughs for invalid forms #24

Closed
tylerIams opened this issue Aug 4, 2019 · 1 comment · Fixed by #35
Closed

Create fall-throughs for invalid forms #24

tylerIams opened this issue Aug 4, 2019 · 1 comment · Fixed by #35

Comments

@tylerIams
Copy link
Member

tylerIams commented Aug 4, 2019

Use the technique described to create fall throughs for invalid forms rather than redirecting to avoid information loss:

https://stackoverflow.com/questions/14647723/django-forms-if-not-valid-show-form-with-error-message/14647770

@tylerIams tylerIams mentioned this issue Aug 12, 2019
6 tasks
@etrepum
Copy link
Member

etrepum commented Aug 13, 2019

Also related, the site doesn't provide any context for what exactly went wrong for a given form submission. It's not even logged to the console. It's really hard to know what you did wrong without more precise feedback than "your form was not valid". Typically form validation will have relevant error messages for the form as a whole and mark relevant fields as invalid (if relevant) so you know where to start. Django forms probably already does this if you don't redirect away.

tylerIams pushed a commit that referenced this issue Aug 14, 2019
tylerIams pushed a commit that referenced this issue Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants