-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ability to have a separate keybind for dismounting #27
Comments
omg, how I have I not added this yet. Yes 100%, this will be added. I'm actually having this same annoyance recently when flying airships |
Instead of displaying as being bound to "Left Shift" by default, it could display as being bound to "Sneak", implying that this control is bound to whatever Sneak is bound to be default, but can be rebound to any other key. |
It's actually not easy to implement this. The server is the one that checks to see if the player is sneaking. So you have to send a packet telling the server you're sneaking and then send another packet to what you're actually doing. But this seems buggy right now, gonna try to get it to work reliably, but no guarantees |
I assume the same is true of #32 and #33 (and possibly #39 and #40)? Can't remember if RandomPatches absorbed the "dedicated dismount key" functionality from a separate mod (it certainly makes no mention of it and I could be mixing it up with something else), but a glance at the code in its repository does reveal relevant code in RPConfig.java, ClientPlayerEntityMixin.java, ClientPlayNetworkHandlerMixin.java and PlayerInputC2SPacketMixin.java that seems relevant (but I am not at all qualified to understand). I should probably check RandomPatches more thoroughly to see if this particular feature is noticeably buggy at all... |
Nevermind, I misunderstood the packet that was being sent. The packet sent for riding (PlayerInputC2SPacket) is different than the ones for moving normally. It's actually a really simple thing when changing the "sneaking" key in this packet doesn't impact sneaking in general. |
Codded, will be in next release |
Released in Version 1.5.0. Modrinth Curseforge Github |
RandomPatches allowed for a separate dismount keybind from the rest of sneaking's functionality, but said mod hasn't updated past 1.16. Could this mod add such a thing?
The text was updated successfully, but these errors were encountered: