Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to have a separate keybind for dismounting #27

Closed
muzikbike opened this issue Dec 28, 2023 · 8 comments
Closed

Ability to have a separate keybind for dismounting #27

muzikbike opened this issue Dec 28, 2023 · 8 comments

Comments

@muzikbike
Copy link

muzikbike commented Dec 28, 2023

RandomPatches allowed for a separate dismount keybind from the rest of sneaking's functionality, but said mod hasn't updated past 1.16. Could this mod add such a thing?
2023-12-28_01 55 02

@muzikbike muzikbike changed the title "Persist after key release Ability to have a separate keybind for dismounting Dec 28, 2023
@Minenash
Copy link
Owner

Minenash commented Mar 7, 2024

omg, how I have I not added this yet. Yes 100%, this will be added. I'm actually having this same annoyance recently when flying airships

@muzikbike
Copy link
Author

Instead of displaying as being bound to "Left Shift" by default, it could display as being bound to "Sneak", implying that this control is bound to whatever Sneak is bound to be default, but can be rebound to any other key.

@Minenash
Copy link
Owner

Minenash commented Apr 4, 2024

It's actually not easy to implement this. The server is the one that checks to see if the player is sneaking. So you have to send a packet telling the server you're sneaking and then send another packet to what you're actually doing. But this seems buggy right now, gonna try to get it to work reliably, but no guarantees

@muzikbike
Copy link
Author

I assume the same is true of #32 and #33 (and possibly #39 and #40)?

Can't remember if RandomPatches absorbed the "dedicated dismount key" functionality from a separate mod (it certainly makes no mention of it and I could be mixing it up with something else), but a glance at the code in its repository does reveal relevant code in RPConfig.java, ClientPlayerEntityMixin.java, ClientPlayNetworkHandlerMixin.java and PlayerInputC2SPacketMixin.java that seems relevant (but I am not at all qualified to understand). I should probably check RandomPatches more thoroughly to see if this particular feature is noticeably buggy at all...

@Minenash
Copy link
Owner

Minenash commented Apr 4, 2024

I assume the same is true of #32 and #33 (and possibly #39 and #40)?

I don't believe so, but those 4 won't be in the next update either way

Minenash added a commit that referenced this issue Apr 5, 2024
- Hotbar Next/Prev is no longer override
- Ability to Rebind Screen primary/seconday buttons
- Fixed Gamemode Selection Text
- Fixed Dropstack modifier not working in inventories
- Started Dismount keybind
@Minenash
Copy link
Owner

Minenash commented Apr 5, 2024

Nevermind, I misunderstood the packet that was being sent. The packet sent for riding (PlayerInputC2SPacket) is different than the ones for moving normally. It's actually a really simple thing when changing the "sneaking" key in this packet doesn't impact sneaking in general.

@Minenash
Copy link
Owner

Minenash commented Apr 5, 2024

Codded, will be in next release

@Minenash Minenash closed this as completed Apr 5, 2024
@Minenash Minenash added the waiting-for-release Will be in the next release label Apr 5, 2024
@Minenash
Copy link
Owner

Minenash commented Apr 7, 2024

Released in Version 1.5.0. Modrinth Curseforge Github

@Minenash Minenash removed the waiting-for-release Will be in the next release label Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants