Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bind "Hotbar Previous/Next" to scroll wheel movement by default, instead of having it as an override #30

Closed
muzikbike opened this issue Mar 7, 2024 · 8 comments

Comments

@muzikbike
Copy link

muzikbike commented Mar 7, 2024

Mojang don't seem to be willing to permit changing this: https://bugs.mojang.com/browse/MC-268283

If #31 is done, we could have this bound to the two normal scroll wheel directions by default.

@Minenash
Copy link
Owner

Minenash commented Mar 7, 2024

This already exists in the mod?

@muzikbike
Copy link
Author

Wait, does it? I might not have checked the controls list thoroughly enough.

@Minenash
Copy link
Owner

Minenash commented Mar 7, 2024

Should be in the inventory section

@muzikbike
Copy link
Author

I see it now. Was thinking that instead of being an override unbound by default, that it would instead be displayed as bound to scrolling by default and rebindable from there (which would require #31):
image

@muzikbike muzikbike changed the title Ability to rebind "move to next/previous hotbar item" Bind "Hotbar Previous/Next" to scroll wheel movement by default, instead of having it as an override Mar 7, 2024
@Minenash
Copy link
Owner

Minenash commented Mar 7, 2024

The problem was that I looked into it before and couldn't figure out how to do it, I can always look again though (having scroll as a bindable thing)

@muzikbike
Copy link
Author

With respect to the most recent commit, it may be advisable to use negative mouse buttons for scroll wheel movement instead, since the USB standard permits button inputs up to 65535. I understand this is an absurd nitpick, but LWJGL should soon allow for more than eight mouse buttons to be usable (glfw/glfw#2423), and since negative mouse buttons will never be accessible this is one way to put them to use instead.

@Minenash Minenash added the waiting-for-release Will be in the next release label Apr 4, 2024
@Minenash
Copy link
Owner

Minenash commented Apr 4, 2024

Codded, will be in next release

@Minenash Minenash closed this as completed Apr 4, 2024
Minenash added a commit that referenced this issue Apr 5, 2024
- Hotbar Next/Prev is no longer override
- Ability to Rebind Screen primary/seconday buttons
- Fixed Gamemode Selection Text
- Fixed Dropstack modifier not working in inventories
- Started Dismount keybind
@Minenash
Copy link
Owner

Minenash commented Apr 7, 2024

Released in Version 1.5.0. Modrinth Curseforge Github

@Minenash Minenash removed the waiting-for-release Will be in the next release label Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants