Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readable-stream v3, nodejs v16 #41

Merged
merged 16 commits into from
Oct 24, 2023
Merged

readable-stream v3, nodejs v16 #41

merged 16 commits into from
Oct 24, 2023

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented Sep 5, 2023

  • BREAKING: Increase minimum Node.js version from 12 to 16
    • ci: Run on Node.js v18,20 instead of 12,14
    • Change recommended Node.js version to 18
  • BREAKING: deps: readable-stream@^2.3.3->^3.6.2
    • deps: replace end-of-stream with port in readable-stream
    • devDeps: replace pump with port in readable-stream

@socket-security
Copy link

socket-security bot commented Sep 5, 2023

New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
readable-stream 3.6.2 None +0 124 kB matteo.collina
@types/readable-stream 2.3.9...4.0.0 None +1/-2 3.92 MB types
@types/node 14.14.9...20.7.1 None +0/-0 3.89 MB types

🚮 Removed packages: @types/[email protected], [email protected], [email protected], [email protected]

@legobeat legobeat mentioned this pull request Sep 5, 2023
@legobeat legobeat marked this pull request as draft September 5, 2023 23:08
@socket-security
Copy link

socket-security bot commented Sep 28, 2023

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

@legobeat legobeat force-pushed the node-16 branch 3 times, most recently from 67980bb to 53c554a Compare September 28, 2023 03:38
@legobeat legobeat added the dependencies Pull requests that update a dependency file label Sep 28, 2023
@legobeat legobeat changed the title BREAKING: Increase minimum Node.js version to 16; recommended to 18 readable-stream v3, nodejs v16 Sep 28, 2023
@legobeat legobeat marked this pull request as ready for review September 28, 2023 04:17
@legobeat legobeat requested review from FrederikBolding, a team and jiexi September 28, 2023 04:19
yarn.lock Outdated Show resolved Hide resolved
@legobeat legobeat requested a review from naugtur October 3, 2023 13:47
@legobeat legobeat requested a review from a team October 16, 2023 11:36
@legobeat legobeat requested review from a team October 24, 2023 00:27
test/index.js Show resolved Hide resolved
src/readable-stream.d.ts Outdated Show resolved Hide resolved
@legobeat legobeat requested a review from kumavis October 24, 2023 07:21
@legobeat legobeat merged commit 3eae042 into MetaMask:main Oct 24, 2023
5 checks passed
@legobeat legobeat mentioned this pull request Oct 24, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants