Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devDeps: @lavamoat/allow-scripts@^1.0.6->^2.5.1 #40

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented Sep 5, 2023

@legobeat legobeat requested a review from a team as a code owner September 5, 2023 21:24
@legobeat legobeat added the dependencies Pull requests that update a dependency file label Sep 5, 2023
@socket-security
Copy link

socket-security bot commented Sep 5, 2023

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: @lavamoat/[email protected]

@socket-security
Copy link

socket-security bot commented Sep 5, 2023

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: [email protected], @lavamoat/[email protected]

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] bar@* or ignore all packages with @SocketSecurity ignore-all

@legobeat legobeat force-pushed the devDeps-lavamoat-allow-scripts branch from 883fedd to 0a4daf9 Compare September 5, 2023 21:45
@legobeat legobeat force-pushed the devDeps-lavamoat-allow-scripts branch 2 times, most recently from 199c3f8 to d8a0828 Compare September 5, 2023 22:08
@legobeat
Copy link
Contributor Author

legobeat commented Sep 5, 2023

@SocketSecurity ignore @lavamoat/[email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore @npmcli/[email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore @tootallnate/[email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore @npmcli/[email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore @lavamoat/[email protected]

@legobeat legobeat force-pushed the devDeps-lavamoat-allow-scripts branch from d8a0828 to 08b7c37 Compare September 5, 2023 22:10
@legobeat legobeat marked this pull request as draft September 5, 2023 22:10
@legobeat legobeat mentioned this pull request Sep 5, 2023
@legobeat legobeat force-pushed the devDeps-lavamoat-allow-scripts branch from 08b7c37 to d00087b Compare September 28, 2023 04:36
@legobeat legobeat changed the title devDeps: @lavamoat/allow-scripts@^1.0.6->^2.3.1 devDeps: @lavamoat/allow-scripts@^1.0.6->^2.5.1 Sep 28, 2023
@legobeat
Copy link
Contributor Author

@SocketSecurity ignore @lavamoat/[email protected]

@legobeat legobeat force-pushed the devDeps-lavamoat-allow-scripts branch from d00087b to 746db69 Compare October 24, 2023 09:11
@legobeat legobeat marked this pull request as ready for review October 24, 2023 09:16
@legobeat legobeat mentioned this pull request Oct 24, 2023
2 tasks
Copy link
Member

@Mrtenz Mrtenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume we're not bumping to ^3.0.0 for Node.js 14/16 compatibility?

@legobeat legobeat merged commit e00bca1 into MetaMask:main Oct 24, 2023
5 checks passed
@legobeat
Copy link
Contributor Author

@Mrtenz Actually no (both min 16). Rather:

$ yarn allow-scripts auto
yarn run v1.22.19
$ /home/user/dev/mm/object-multiplex/node_modules/.bin/allow-scripts auto
/home/user/dev/mm/object-multiplex/node_modules/@lavamoat/allow-scripts/node_modules/cliui/build/index.cjs:293
const wrap = require('wrap-ansi');
             ^

Error [ERR_REQUIRE_ESM]: require() of ES Module /home/user/dev/mm/object-multiplex/node_modules/wrap-ansi/index.js from /home/user/dev/mm/object-multiplex/node_modules/@lavamoat/allow-scripts/node_modules/cliui/build/index.cjs not supported.
Instead change the require of index.js in /home/user/dev/mm/object-multiplex/node_modules/@lavamoat/allow-scripts/node_modules/cliui/build/index.cjs to a dynamic import() which is available in all CommonJS modules.
    at Object.<anonymous> (/home/user/dev/mm/object-multiplex/node_modules/@lavamoat/allow-scripts/node_modules/cliui/build/index.cjs:293:14)
    at Object.<anonymous> (/home/user/dev/mm/object-multiplex/node_modules/@lavamoat/allow-scripts/node_modules/yargs/build/index.cjs:1:60678)
    at Object.<anonymous> (/home/user/dev/mm/object-multiplex/node_modules/@lavamoat/allow-scripts/node_modules/yargs/yargs:3:69)
    at Object.<anonymous> (/home/user/dev/mm/object-multiplex/node_modules/@lavamoat/allow-scripts/src/cli.js:3:15) {
  code: 'ERR_REQUIRE_ESM'
}
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

@legobeat
Copy link
Contributor Author

legobeat commented Oct 24, 2023

@Mrtenz Actually no, this package is already on 16 (which @lavamoat/allow-scripts still supports) but we get this when trying to run with v3.

$ yarn allow-scripts auto
yarn run v1.22.19
$ node_modules/.bin/allow-scripts auto
node_modules/@lavamoat/allow-scripts/node_modules/cliui/build/index.cjs:293
const wrap = require('wrap-ansi');
             ^

Error [ERR_REQUIRE_ESM]: require() of ES Module node_modules/wrap-ansi/index.js from node_modules/@lavamoat/allow-scripts/node_modules/cliui/build/index.cjs not supported.
Instead change the require of index.js in node_modules/@lavamoat/allow-scripts/node_modules/cliui/build/index.cjs to a dynamic import() which is available in all CommonJS modules.
    at Object.<anonymous> (node_modules/@lavamoat/allow-scripts/node_modules/cliui/build/index.cjs:293:14)
    at Object.<anonymous> (node_modules/@lavamoat/allow-scripts/node_modules/yargs/build/index.cjs:1:60678)
    at Object.<anonymous> (node_modules/@lavamoat/allow-scripts/node_modules/yargs/yargs:3:69)
    at Object.<anonymous> (node_modules/@lavamoat/allow-scripts/src/cli.js:3:15) {
  code: 'ERR_REQUIRE_ESM'
}
error Command failed with exit code 1.

Will have to look at that separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants