chore(deps): readable-stream@^2.3.3->^3.6.2 #39
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated dependencies detected. Learn more about Socket for GitHub ↗︎
|
Merged
| @@ -49,7 +49,7 @@ | |||
| "eslint-plugin-node": "^11.1.0", | |||
| "eslint-plugin-prettier": "^3.4.0", | |||
| "prettier": "^2.3.0", | |||
| "pump": "^1.0.2", | |||
| "pump": "^2.0.0", | |||
There was a problem hiding this comment.
@legobeat Could we use stream / readable-stream instead?
pump should equal pipeline and end-of-stream should equal finished
https://github.com/nodejs/readable-stream/blob/main/lib/stream.js#L100-L103
There was a problem hiding this comment.
The node engines update and the readable-stream bump are interdependent so closing this in favor of #41 , where pump and end-of-stream are now removed.
|
Closing in favor of: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked by: