-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metametrics #6171
Merged
Merged
Metametrics #6171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will rebase onto #6192 once merged |
…ttings, sig requests and main screen
danjm
force-pushed
the
metametrics
branch
3 times, most recently
from
February 28, 2019 12:25
5fec1f1
to
f507c5f
Compare
Good catch again. Fixed now. |
…dMetaMetrics event and confrim tx base
whymarrh
approved these changes
Mar 5, 2019
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the analytics system described here https://medium.com/metamask/metametrics-an-introduction-to-metamasks-new-analytics-system-e9749e74a275
Code related to the sending of metrics can be reviewed. Reviewers may find it easy to review commit by commit.
Outstanding UI tasks include: