Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metametrics #6171

Merged
merged 50 commits into from
Mar 5, 2019
Merged

Metametrics #6171

merged 50 commits into from
Mar 5, 2019

Conversation

danjm
Copy link
Contributor

@danjm danjm commented Feb 15, 2019

This PR implements the analytics system described here https://medium.com/metamask/metametrics-an-introduction-to-metamasks-new-analytics-system-e9749e74a275

Code related to the sending of metrics can be reviewed. Reviewers may find it easy to review commit by commit.

Outstanding UI tasks include:

  • Add correct chart graphic on opt-in screen
  • Update the opt-in modal (for existing users) to latest designs
  • Apply the responsive design to the opt-in modal
  • Make other first time flow changes on which this will depend
  • Rebase this onto first time flow changes
  • Update tests

peek 2019-02-28 13-04

@danjm
Copy link
Contributor Author

danjm commented Feb 19, 2019

Now with responsive designs

peek 2019-02-18 23-15

@danjm
Copy link
Contributor Author

danjm commented Feb 21, 2019

Will rebase onto #6192 once merged

@danjm danjm force-pushed the metametrics branch 3 times, most recently from 5fec1f1 to f507c5f Compare February 28, 2019 12:25
@danjm
Copy link
Contributor Author

danjm commented Mar 1, 2019

I think opting IN to metrics is being recorded as opting out

Good catch again. Fixed now.

@metamaskbot
Copy link
Collaborator

Builds ready [2dbc223]: mascara, chrome, firefox, edge, opera

@metamaskbot
Copy link
Collaborator

Builds ready [53356fd]: mascara, chrome, firefox, edge, opera

@danjm danjm merged commit c757366 into develop Mar 5, 2019
@whymarrh whymarrh deleted the metametrics branch March 5, 2019 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants