-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metametrics #6171
Merged
Merged
Metametrics #6171
Changes from all commits
Commits
Show all changes
50 commits
Select commit
Hold shift + click to select a range
058f658
Add metametrics provider and util.
danjm 41e51b3
Add backend api and state for participating in metametrics.
danjm 0849337
Add frontend action for participating in metametrics.
danjm 87c06c1
Add metametrics opt-in screen.
danjm d39011f
Add metametrics events to first time flow.
danjm 29ff3b6
Add metametrics events for route changes
danjm 6cf113f
Add metametrics events for send and confirm screens
danjm c29348d
Add metametrics events to dropdowns, transactions, log in and out, se…
danjm 35e3175
Ensures each log in is measured as a new visit by metametrics.
danjm bee4e15
Ensure metametrics is called with an empty string for dimensions para…
danjm 38ad6e1
Adds opt in metametrics modal after unlock for existing users
danjm 9ce1182
Adds settings page toggle for opting in and out of MetaMetrics
danjm e4ced75
Switch metametrics dimensions to page level scope
danjm 3284348
Lint, test and translation fixes for metametrics.
danjm 2132777
Update design for metametrics opt-in screen
danjm dc97baf
Complete responsive styling of metametrics-opt-in modal
danjm a1145ea
Use new chart image on metrics opt in screens
danjm 88e0cc7
Incorporate the metametrics opt-in screen into the new onboarding flow
danjm 4c8eb5c
Update e2e tests to accomodate metametrics changes
danjm 65caafc
Mock out metametrics network requests in integration tests
danjm ae58572
Fix tx-list integration test to support metametrics provider.
danjm ec2934d
Send number of tokens and accounts data with every metametrics event.
danjm 556bc99
Update metametrics event descriptor schema and add new events.
danjm d5d54d7
Fix import tos bug and send gas button bug due to metametrics changes.
danjm 5fe45cf
Various small fixes on the metametrics branch.
danjm 88055b5
Add origin custom variable type to metametrics.util
danjm 2061a61
Fix names of onboarding complete actions (metametrics).
danjm 268ae09
Fix names of Metrics Options actions (metametrics).
danjm debd058
Clean up code related to metametrics.
danjm d33f434
Fix bad merge conflict resolution and improve promise handling in sen…
danjm c4ee46d
Don't send a second metrics event if user has gone back during first …
danjm f20eb10
Collect metametrics on going back from onboarding create/import.
danjm 55b09f2
Add missing custom variable constants for metametrics
danjm 4a74b0a
Fix metametrics provider
danjm 9a6f943
Make height of opt-in modal responsive.
danjm 8eadc38
Adjust text content for opt-in modal.
danjm 8ea5215
Update metametrics event names and clean up code in opt-in-modal
danjm 8b7b253
Put phishing warning step next to last in onboarding flow
danjm ae8d9c0
Link terms of service on create and import screens of first time flow
danjm c5641b1
Add subtext to options on the onboarding select action screen.
danjm d629c2e
Fix styling of bullet points on end of onboarding screen.
danjm 12f19bb
Combine phishing warning and congratulations screens.
danjm c762b8b
Fix placement of users if unlocking after an incomplete onboarding im…
danjm 48508c6
Fix capitalization in opt-in screen
danjm d904233
Fix last onboarding screen translations
danjm a3afffb
Add link to 'Learn More' on the last screen of onboarding
danjm 1e5d8fa
Code clean up: metametrics branch
danjm 1f3bdc9
Update e2e tests for phishing warning step removal
danjm 2dbc223
e2e tests passing on metametrics branch
danjm 53356fd
Different tracking urls for metametrics on development and prod
danjm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -470,15 +470,21 @@ | |
"message": "Tips on storing it safely" | ||
}, | ||
"endOfFlowMessage3": { | ||
"message": "Save a backup in multiple places" | ||
"message": "Save a backup in multiple places." | ||
}, | ||
"endOfFlowMessage4": { | ||
"message": "Never tell anyone" | ||
"message": "Never share the phrase with anyone." | ||
}, | ||
"endOfFlowMessage5": { | ||
"message": "If you need to back your seed phrase again, you can find it in Settings -> Security." | ||
"message": "Be careful of phishing! MetaMask will never spontaneously ask for your seed phrase." | ||
}, | ||
"endOfFlowMessage6": { | ||
"message": "If you need to back your up seed phrase again, you can find it in Settings -> Security." | ||
}, | ||
"endOfFlowMessage7": { | ||
"message": "If you ever have questions or see something fishy, email [email protected]." | ||
}, | ||
"endOfFlowMessage8": { | ||
"message": "MetaMask cannot recover your seedphrase. Learn more." | ||
}, | ||
"ensNameNotFound": { | ||
|
@@ -689,6 +695,9 @@ | |
"importWallet": { | ||
"message": "Import Wallet" | ||
}, | ||
"importYourExisting": { | ||
"message": "Import your existing wallet using a 12 word seed phrase" | ||
}, | ||
"imported": { | ||
"message": "Imported", | ||
"description": "status showing that an account has been fully loaded into the keyring" | ||
|
@@ -1000,6 +1009,12 @@ | |
"originalTotal": { | ||
"message": "Original Total" | ||
}, | ||
"participateInMetaMetrics": { | ||
"message": "Participate in MetaMetrics" | ||
}, | ||
"participateInMetaMetricsDesciption": { | ||
"message": "Participate in MetaMetrics to help us make MetaMask better" | ||
}, | ||
"password": { | ||
"message": "Password" | ||
}, | ||
|
@@ -1435,6 +1450,9 @@ | |
"testFaucet": { | ||
"message": "Test Faucet" | ||
}, | ||
"thisWillCreate": { | ||
"message": "This will create a new wallet and seed phrase" | ||
}, | ||
"tips": { | ||
"message": "Tips" | ||
}, | ||
|
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1403,5 +1403,6 @@ | |
], | ||
"priceAndTimeEstimatesLastRetrieved": 1541527901281, | ||
"errors": {} | ||
} | ||
}, | ||
"confirmTransaction": {} | ||
} |
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The TOS needs to be clicked after the seed phrase and password is entered.