Improved Spanish translation of Contract interaction #6072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Makes sense. Thanks! |
estebanmino
reviewed
Jan 30, 2019
| @@ -931,7 +931,7 @@ | |||
| "message": "Tu firma ya fue solicitada" | |||
| }, | |||
| "contractInteraction": { | |||
| "message": "Interacción del Contrato" | |||
| "message": "Interacción con contrato" | |||
There was a problem hiding this comment.
should we maintain capital letter on the word contrato?
There was a problem hiding this comment.
It's usual in English but is not correct in Spanish. It's true that is being more common in Spanish because of English influence.
|
@Pedro-vk would you mind rebasing this the latest |
whymarrh
approved these changes
Jan 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.