Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Typescript conversion of switch-ethereum-chain.js #23902

Open
wants to merge 2 commits into
base: ts-ethereum-chain-utils
Choose a base branch
from

Conversation

NiranjanaBinoy
Copy link
Contributor

@NiranjanaBinoy NiranjanaBinoy commented Apr 9, 2024

Part of #23014
Fixes #23473

Converting the level 6 dependency file app/scripts/lib/rpc-method-middleware/handlers/switch-ethereum-chain.js to typescript for contributing to metamask-controller.js.

Description

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Apr 9, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

socket-security bot commented Apr 9, 2024

No dependency changes detected. Learn more about Socket for GitHub ↗︎

👍 No dependency changes detected in pull request

Copy link
Contributor

github-actions bot commented Jun 8, 2024

This PR has been automatically marked as stale because it has not had recent activity in the last 60 days. It will be closed in 14 days. Thank you for your contributions.

@github-actions github-actions bot added the stale issues and PRs marked as stale label Jun 8, 2024
Copy link
Contributor

This PR was closed because there has been no follow up activity in the last 14 days. Thank you for your contributions.

@github-actions github-actions bot closed this Jun 22, 2024
@github-actions github-actions bot removed the stale issues and PRs marked as stale label Jun 28, 2024
@NiranjanaBinoy NiranjanaBinoy changed the base branch from extract-wrapper-type to develop August 14, 2024 19:00
Copy link

@NiranjanaBinoy NiranjanaBinoy changed the base branch from develop to ts-ethereum-chain-utils August 15, 2024 20:18
Copy link

codecov bot commented Aug 15, 2024

Codecov Report

Attention: Patch coverage is 78.94737% with 4 lines in your changes missing coverage. Please review.

Project coverage is 69.99%. Comparing base (4111fb1) to head (9731edf).

Files with missing lines Patch % Lines
...ethod-middleware/handlers/switch-ethereum-chain.ts 78.95% 4 Missing ⚠️
Additional details and impacted files
@@                     Coverage Diff                     @@
##           ts-ethereum-chain-utils   #23902      +/-   ##
===========================================================
- Coverage                    70.12%   69.99%   -0.14%     
===========================================================
  Files                         1428     1422       -6     
  Lines                        50107    49932     -175     
  Branches                     13897    13864      -33     
===========================================================
- Hits                         35136    34945     -191     
- Misses                       14971    14987      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [9731edf]
Page Load Metrics (316 ± 334 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint842501183416
domContentLoaded105827168
load522449316696334
domInteractive105827168
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 191 Bytes (0.01%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@NiranjanaBinoy NiranjanaBinoy marked this pull request as ready for review August 15, 2024 20:50
@NiranjanaBinoy NiranjanaBinoy requested a review from a team as a code owner August 15, 2024 20:50
Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity in the last 60 days. It will be closed in 14 days. Thank you for your contributions.

@github-actions github-actions bot added stale issues and PRs marked as stale and removed stale issues and PRs marked as stale labels Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert switch-ethereum-chain.js to Typescript
3 participants