-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Typescript conversion of switch-ethereum-chain.js #23902
base: ts-ethereum-chain-utils
Are you sure you want to change the base?
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
No dependency changes detected. Learn more about Socket for GitHub ↗︎ 👍 No dependency changes detected in pull request |
This PR has been automatically marked as stale because it has not had recent activity in the last 60 days. It will be closed in 14 days. Thank you for your contributions. |
This PR was closed because there has been no follow up activity in the last 14 days. Thank you for your contributions. |
360dded
to
64bbbf2
Compare
Quality Gate passedIssues Measures |
64bbbf2
to
9731edf
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## ts-ethereum-chain-utils #23902 +/- ##
===========================================================
- Coverage 70.12% 69.99% -0.14%
===========================================================
Files 1428 1422 -6
Lines 50107 49932 -175
Branches 13897 13864 -33
===========================================================
- Hits 35136 34945 -191
- Misses 14971 14987 +16 ☔ View full report in Codecov by Sentry. |
Builds ready [9731edf]
Page Load Metrics (316 ± 334 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
This PR has been automatically marked as stale because it has not had recent activity in the last 60 days. It will be closed in 14 days. Thank you for your contributions. |
Part of #23014
Fixes #23473
Converting the level 6 dependency file
app/scripts/lib/rpc-method-middleware/handlers/switch-ethereum-chain.js
to typescript for contributing tometamask-controller.js
.Description
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist