Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert partial level 6 files to typescript for contributing to metamask-controller.js #23014

Open
DDDDDanica opened this issue Feb 16, 2024 · 0 comments
Open

Convert partial level 6 files to typescript for contributing to metamask-controller.js #23014

DDDDDanica opened this issue Feb 16, 2024 · 0 comments
Assignees
@MajorLift
Labels
in-progress team-extension-platform

Comments

@DDDDDanica
Copy link
Contributor

DDDDDanica commented Feb 16, 2024 •
edited
Loading

Convert dependency of files for metamask-controller.js (level 2) we want to target based on typescript migration dashboard.

Level 6

  • app/scripts/lib/rpc-method-middleware/handlers/add-ethereum-chain.js
  • app/scripts/lib/rpc-method-middleware/handlers/eth-accounts.js
  • app/scripts/lib/rpc-method-middleware/handlers/get-provider-state.js
  • app/scripts/lib/rpc-method-middleware/handlers/log-web3-shim-usage.js
  • app/scripts/lib/rpc-method-middleware/handlers/request-accounts.js
  • app/scripts/lib/rpc-method-middleware/handlers/send-metadata.js
  • app/scripts/lib/rpc-method-middleware/handlers/switch-ethereum-chain.js
  • app/scripts/lib/rpc-method-middleware/handlers/watch-asset.js
@DDDDDanica DDDDDanica added the INVALID-ISSUE-TEMPLATE Issue's body doesn't match any issue template. label Feb 16, 2024
@DDDDDanica DDDDDanica changed the title Copy of Convert partial level 13 files to typescript for contributing to metamask-controller.js Convert partial level 6 files to typescript for contributing to metamask-controller.js Feb 16, 2024
@DDDDDanica DDDDDanica added team-extension-platform and removed INVALID-ISSUE-TEMPLATE Issue's body doesn't match any issue template. labels Feb 16, 2024
@DDDDDanica DDDDDanica self-assigned this Mar 12, 2024
This was referenced Mar 13, 2024
Open
Closed
Closed
Closed
Open
Open
Open
Open
This was referenced Apr 9, 2024
Merged
Closed
Merged
Merged
Open
Open
Closed
Open
Draft
This was referenced Jul 24, 2024
Open
Open
@MajorLift MajorLift mentioned this issue Aug 20, 2024
Merged
8 tasks
github-merge-queue bot pushed a commit that referenced this issue Oct 2, 2024
@NiranjanaBinoy @MajorLift
refactor: Typescript conversion of get-provider-state.js (#23635)
a7aacf8 
Part of #23014 
Fixes #23469 

Converting the level 6 dependency file
`app/scripts/lib/rpc-method-middleware/handlers/get-provider-state.js`
to typescript for contributing to `metamask-controller.js`.

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/23635?quickstart=1)

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've clearly explained what problem this PR is solving and how it
is solved.
- [ ] I've linked related issues
- [ ] I've included manual testing steps
- [ ] I've included screenshots/recordings if applicable
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
- [ ] I’ve properly set the pull request status:
  - [ ] In case it's not yet "ready for review", I've set it to "draft".
- [ ] In case it's "ready for review", I've changed it from "draft" to
"non-draft".

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

---------

Co-authored-by: Jongsun Suh <[email protected]>
github-merge-queue bot pushed a commit that referenced this issue Oct 8, 2024
@NiranjanaBinoy
refactor: Typescript conversion of log-web3-shim-usage.js (#23732)
29bc2f5 
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->
Part of #23014 
Fixes #23470 

Converting the level 6 dependency file
`app/scripts/lib/rpc-method-middleware/handlers/log-web3-shim-usage.js`
to typescript for contributing to `metamask-controller.js`.
## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/23732?quickstart=1)

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MajorLift MajorLift

Labels
in-progress team-extension-platform
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@DDDDDanica @MajorLift @metamaskbot @NiranjanaBinoy