refactor: Typescript conversion of watch-asset.js

[NiranjanaBinoy]

Part of #23014
Fixes #23474

Converting the level 6 dependency file app/scripts/lib/rpc-method-middleware/handlers/watch-asset.js to typescript for contributing to metamask-controller.js.

Description

Related issues

Fixes:

Manual testing steps

1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[DDDDDanica]

Suggested change

	methodNames: [MESSAGE_TYPE.WATCH_ASSET],
	methodNames: [MESSAGE_TYPE.WATCH_ASSET, MESSAGE_TYPE.WATCH_ASSET_LEGACY],

[DDDDDanica]

Can we add a return type here?

[DDDDDanica]

BTW we can directly merge to develop :)

merge 2 commits into extract-wrapper-type from ts-watch-asset

[github-actions]

This PR has been automatically marked as stale because it has not had recent activity in the last 60 days. It will be closed in 14 days. Thank you for your contributions.

[github-actions]

This PR was closed because there has been no follow up activity in the last 14 days. Thank you for your contributions.

[greptile-apps]

PR Summary

Converted watch-asset.js to TypeScript, enhancing type safety and maintainability.

• New Type Definitions: Added app/scripts/lib/rpc-method-middleware/handlers/types.ts to define TypeScript types for the watch-asset handler.
• File Removal: Deleted app/scripts/lib/rpc-method-middleware/handlers/watch-asset.js as part of the TypeScript conversion.
• TypeScript Conversion: Created app/scripts/lib/rpc-method-middleware/handlers/watch-asset.ts to replace the JavaScript file, ensuring type safety and maintaining the same functionality.

_{3 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings}

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[metamaskbot]

Builds ready [2ec2750]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (73 ± 22 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	72	297	113	61	30
		domContentLoaded	9	93	31	24	12
		load	38	206	73	45	22
		domInteractive	9	93	31	24	12

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: 0 Bytes (0.00%)
• common: 0 Bytes (0.00%)

[codecov]

Codecov Report

Attention: Patch coverage is 92.85714% with 1 line in your changes missing coverage. Please review.

Project coverage is 69.98%. Comparing base (cdd543d) to head (2ec2750).
Report is 1133 commits behind head on develop.

Files with missing lines	Patch %	Lines
.../lib/rpc-method-middleware/handlers/watch-asset.ts	92.86%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff            @@
##           develop   #23776   +/-   ##
========================================
  Coverage    69.98%   69.98%           
========================================
  Files         1422     1422           
  Lines        49926    49926           
  Branches     13861    13861           
========================================
  Hits         34940    34940           
  Misses       14986    14986           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

This PR has been automatically marked as stale because it has not had recent activity in the last 60 days. It will be closed in 14 days. Thank you for your contributions.