[FLASK] Create new E2E test for snap_getLocale #20861

bowensanders · 2023-09-13T18:11:40Z

Creates a new E2E test for the snap_getLocale function.

github-actions · 2023-09-13T18:11:54Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

test/e2e/snaps/enums.js

test/e2e/snaps/test-snap-get-locale.spec.js

Co-authored-by: Frederik Bolding <[email protected]>

metamaskbot · 2023-09-21T19:48:46Z

Builds ready [d5d7f66]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5, 6
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1674 ± 85 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	119	205	148	26	13
		domContentLoaded	1432	2020	1674	177	85
		load	1432	2020	1674	177	85
		domInteractive	1432	2019	1674	177	85

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

codecov · 2023-09-21T19:48:53Z

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (7f6ea72) 68.34% compared to head (0092824) 68.34%.
Report is 2 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop   #20861   +/-   ##
========================================
  Coverage    68.34%   68.34%           
========================================
  Files         1007     1007           
  Lines        40266    40266           
  Branches     10771    10771           
========================================
  Hits         27519    27519           
  Misses       12747    12747

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

metamaskbot · 2023-09-21T21:00:42Z

Builds ready [c029171]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5, 6
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1695 ± 59 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	125	181	153	19	9
		domContentLoaded	1499	1999	1694	122	59
		load	1499	1999	1695	122	59
		domInteractive	1499	1999	1694	122	59

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2023-09-22T16:22:35Z

Builds ready [add0d6d]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5, 6, 7
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1500 ± 27 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	114	217	138	24	12
		domContentLoaded	1387	1615	1499	56	27
		load	1388	1615	1500	56	27
		domInteractive	1387	1615	1499	56	27

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

FrederikBolding

Wait with merging this until #21019 is merged

metamaskbot · 2023-09-25T15:22:49Z

Builds ready [55c44d6]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5, 6
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1867 ± 81 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	93	152	118	17	8
		domContentLoaded	81	147	108	19	9
		load	1559	2255	1867	168	81
		domInteractive	81	147	108	19	9

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

test/e2e/snaps/enums.js

Co-authored-by: Maarten Zuidhoorn <[email protected]>

metamaskbot · 2023-09-27T08:30:02Z

Builds ready [0092824]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5, 6
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (912 ± 388 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	88	148	111	18	9
		domContentLoaded	70	129	102	20	10
		load	81	1868	912	808	388
		domInteractive	70	129	102	20	10

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

created new e2e

612c152

bowensanders added the flask label Sep 13, 2023

bowensanders self-assigned this Sep 13, 2023

bowensanders added 6 commits September 13, 2023 13:37

fixed enums

eca7618

disabled test in run-all.js

2ce3e45

added safe-scroll

f42ba7e

Merge branch 'develop' into testorama

fca2d17

Merge branch 'develop' into testorama

a27be41

Merge branch 'develop' into testorama

cfe4bed

FrederikBolding reviewed Sep 21, 2023

View reviewed changes

test/e2e/snaps/enums.js Outdated Show resolved Hide resolved

test/e2e/snaps/test-snap-get-locale.spec.js Show resolved Hide resolved

Update test/e2e/snaps/enums.js

d5d7f66

Co-authored-by: Frederik Bolding <[email protected]>

bowensanders mentioned this pull request Sep 21, 2023

[FLASK] Create E2E test for snaps_getLocale #20846

Closed

bowensanders added 2 commits September 21, 2023 13:24

added locale change and test

d9586ce

Merge branch 'develop' into testorama

c029171

bowensanders marked this pull request as ready for review September 21, 2023 21:33

bowensanders requested review from a team as code owners September 21, 2023 21:33

bowensanders added the team-snaps DEPRECATED: Use "team-snaps-platform" or "team-snaps-ecosystem" instead label Sep 21, 2023

FrederikBolding previously approved these changes Sep 22, 2023

View reviewed changes

Merge branch 'develop' into testorama

add0d6d

bowensanders dismissed FrederikBolding’s stale review via add0d6d September 22, 2023 15:41

FrederikBolding requested changes Sep 25, 2023

View reviewed changes

FrederikBolding added 2 commits September 25, 2023 15:27

Merge branch 'develop' into testorama

97aa3ec

Merge branch 'develop' into testorama

55c44d6

FrederikBolding previously approved these changes Sep 25, 2023

View reviewed changes

Mrtenz requested changes Sep 26, 2023

View reviewed changes

test/e2e/snaps/enums.js Outdated Show resolved Hide resolved

bowensanders dismissed FrederikBolding’s stale review via be43fcb September 26, 2023 16:19

Update enums.js

be43fcb

Co-authored-by: Maarten Zuidhoorn <[email protected]>

bowensanders requested review from FrederikBolding and Mrtenz September 26, 2023 17:05

Mrtenz previously approved these changes Sep 26, 2023

View reviewed changes

fixed lint error

f26c3ac

bowensanders dismissed Mrtenz’s stale review via f26c3ac September 26, 2023 18:26

Merge branch 'develop' into testorama

0092824

FrederikBolding approved these changes Sep 26, 2023

View reviewed changes

Mrtenz approved these changes Sep 26, 2023

View reviewed changes

bowensanders mentioned this pull request Sep 26, 2023

[FLASK] Create new E2E test for snap_getLocale (new) #21053

Closed

FrederikBolding merged commit 6e4bf67 into develop Sep 27, 2023
9 checks passed

FrederikBolding deleted the testorama branch September 27, 2023 08:20

github-actions bot locked and limited conversation to collaborators Sep 27, 2023

metamaskbot added the release-11.3.0 Issue or pull request that will be included in release 11.3.0 label Sep 27, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[FLASK] Create new E2E test for snap_getLocale #20861

[FLASK] Create new E2E test for snap_getLocale #20861

bowensanders commented Sep 13, 2023

github-actions bot commented Sep 13, 2023

metamaskbot commented Sep 21, 2023

codecov bot commented Sep 21, 2023 •

edited

Loading

metamaskbot commented Sep 21, 2023

metamaskbot commented Sep 22, 2023

FrederikBolding left a comment

metamaskbot commented Sep 25, 2023

metamaskbot commented Sep 27, 2023

[FLASK] Create new E2E test for snap_getLocale #20861

[FLASK] Create new E2E test for snap_getLocale #20861

Conversation

bowensanders commented Sep 13, 2023

github-actions bot commented Sep 13, 2023

metamaskbot commented Sep 21, 2023

codecov bot commented Sep 21, 2023 • edited Loading

Codecov Report

metamaskbot commented Sep 21, 2023

metamaskbot commented Sep 22, 2023

FrederikBolding left a comment

Choose a reason for hiding this comment

metamaskbot commented Sep 25, 2023

metamaskbot commented Sep 27, 2023

codecov bot commented Sep 21, 2023 •

edited

Loading