fix: filteredTests problem from #20974

[HowardBraham]

Description

#20974 introduced a problem where now those filteredTests are not running in any CI step, this fixes it

This is the problematic change. I added --build-type=flask to lines in config.yml to fix it.

Also, there's an enormous amount of spam in the logs with lines like this

[driver] Called 'scrollToElement' with arguments [{"driver_":{"session_":{},"executor_":{"customCommands_":{},"log_":{"name_":"webdriver.http.Executor","level_":null,"parent_":{"name_":"webdriver.http","level_":null,"parent_":{"name_":"webdriver","level_":null,"parent_":{"name_":"","level_":{"name_":"OFF","value_":null},"parent_":null,"handlers_":null},"handlers_":null},"handlers_":null},"handlers_":null},"w3c":true},"fileDetector_":null,"authenticatorId_":null,"pinnedScripts_":{},"_wsUrl":"ws://127.0.0.1:41845/devtools/page/ED4EC848C3E7A22AFFB6B7BF1D20D367","_wsConnection":{"_events":{"message":
,"_outBuffer":{"type":"Buffer","data":[81,157,118,103,214,2,116,101,170,121,238,32,178,231,246,101,214,26,191,72,243,96,228,99,188,226,175,2,154,155,183,42,0,0,255,255,143,36,240,206,9,56,22,171,115,192,112,208,15,115,17,255,167,70,98,60,189,106,194,188,159,232,96,30,60,40,194,158,61,41,192,189,191,200,131,62,188,74,96,191,126,74,225,189,31,105,218,115,130,151,254,16,177,214,60,175,124,231,206,19,131,164,48,230,125,116,78,203,105,188,210,79,162,2,123,144,63,164,216,134,0,0,255,255,11,37,147,194,26,199,234,197,0,241,237,49,23,253,221,249,27,217,169,207,252,6,13,201,56,253,242,234,47,233,157,67,24,241,101,157,223,241,237,125,111,113,197,85,231,57,77,141,79,1,77,61,199,81,173,157,47,241,197,53,7,49,37,21,135,221,54,155,73,0,0,255,255,0,0,0,227,241,255,255,0,0,0,0,0,0,0,0,0,0,0,0,168,229,241,230,29,127,0,0,176,229,241,230,29,127,0,0,227,241,255,255,0,0,0,0,125,241,255,255,0,0,0,0,0,0,0

I put in something to limit the length of a [driver] log entry to 200 characters.

Manual testing steps

1. Look at test-e2e-chrome-snaps-flask on develop
   a. Note that, for instance, "Test Snap Lifecycle Hooks" are not being run
   b. Note the huge amount of log spam
2. Look at test-e2e-chrome-snaps-flask on this PR
   a. Note that "Test Snap Lifecycle Hooks" are being run (look in parallel run number 2)
   b. Note the lack of log spam

Related issues

Fixes problem in #20974

Pre-merge author checklist

• I’ve followed MetaMask Coding Standards.
• I've clearly explained:
  • What problem this PR is solving.
  • How this problem was solved.
  • How reviewers can test my changes.
• I’ve indicated what issue this PR is linked to: Fixes #???
• I’ve included tests if applicable.
• I’ve documented any added code.
• I’ve applied the right labels on the PR (see labeling guidelines).
• I’ve properly set the pull request status:
  • In case it's not yet "ready for review", I've set it to "draft".
  • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[codecov]

Codecov Report

Patch and project coverage have no change.

Comparison is base (315c043) 68.34% compared to head (89fe9ef) 68.34%.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop   #21019   +/-   ##
========================================
  Coverage    68.34%   68.34%           
========================================
  Files         1007     1007           
  Lines        40254    40254           
  Branches     10761    10761           
========================================
  Hits         27508    27508           
  Misses       12746    12746           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[metamaskbot]

Builds ready [89fe9ef]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4
  • common: 0, 1, 2, 3, 4, 5, 6, 7
  • content-script: 0
  • contentscript: contentscript
  • disable-console: disable-console
  • inpage: inpage
  • policy-load: policy-load
  • sentry-install: sentry-install
  • ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1622 ± 42 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	87	139	102	14	7
		domContentLoaded	70	136	98	16	8
		load	1476	1805	1622	88	42
		domInteractive	70	136	98	16	8

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: 0 Bytes (0.00%)
• common: 0 Bytes (0.00%)

[Gudahtt]

LGTM!

[Gudahtt]

Interesting, so this missing build-type flag pre-dates #20974 correct? But it was still running the tests before #20974 because the filtering used not take effect if the build type wasn't set. Now it always filters for non-flask.

The way it works now seems better. Pretty confusing for the filtering to happen on main but not if no build type was set, given that main is the default. Good catch!