[FLASK] Create E2E test for snaps_getLocale #20846
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…20786) * Move the `saveSnapKeyring` callback to the `SnapKeyring` constructor This commit removes `saveSnapKeyring` from the list of callbacks passed to the Snap Controller since this function contains business logic specific to the Snap Keyring. Instead, `saveSnapKeyring` is injected into the Snap Keyring through a new argument called `callbacks`. In the future, the `callbacks` argument can be reused to pass other callbacks. * Update the Snap Keyring dependency * chore: use release versions of `eth-snap-keyring` and `rpc-methods` * chore: update `yarn.lock` * chore: update `yarn.lock`
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [56310e5]
Page Load Metrics (1748 ± 56 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
|
Stale. Replaced by #20861 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates an E2E test for snaps_getLocale.
This is also contingent upon the merge of #20567