[FLASK] Bump snaps packages #20567
Merged
[FLASK] Bump snaps packages #20567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrederikBolding
added
flask
team-snaps
FrederikBolding
force-pushed
the
fb/snaps-flask-bump
branch
from
12a7abf to
3d84dbd
Compare
FrederikBolding
force-pushed
the
fb/snaps-flask-bump
branch
from
3d84dbd to
9c3d883
Compare
Builds ready [947cb0e]
Page Load Metrics (1829 ± 93 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
…20786) * Move the `saveSnapKeyring` callback to the `SnapKeyring` constructor This commit removes `saveSnapKeyring` from the list of callbacks passed to the Snap Controller since this function contains business logic specific to the Snap Keyring. Instead, `saveSnapKeyring` is injected into the Snap Keyring through a new argument called `callbacks`. In the future, the `callbacks` argument can be reused to pass other callbacks. * Update the Snap Keyring dependency * chore: use release versions of `eth-snap-keyring` and `rpc-methods` * chore: update `yarn.lock` * chore: update `yarn.lock`
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #20567 +/- ##
===========================================
- Coverage 68.20% 68.20% -0.00%
===========================================
Files 999 999
Lines 39846 39855 +9
Branches 10669 10671 +2
===========================================
+ Hits 27174 27180 +6
- Misses 12672 12675 +3
☔ View full report in Codecov by Sentry. |
Mrtenz
approved these changes
Sep 12, 2023
Builds ready [56310e5]
Page Load Metrics (2196 ± 170 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
hmalik88
approved these changes
Sep 12, 2023
metamaskbot
added
the
release-11.2.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Bumps Snaps Flask packages to the latest version and handles any breaking changes.
This PR also adds support for
snap_getLocale.