Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added 50% border radius support to the Box component #16486

Merged
merged 3 commits into from
Nov 14, 2022

Conversation

NidhiKJha
Copy link
Member

@NidhiKJha NidhiKJha commented Nov 14, 2022

This PR is to add 50% border-radius support to the box component for the circle UI

After

Screenshot 2022-11-14 at 9 35 07 PM

Manual Testing Steps

yarn test:unit:jest .ui/components/ui/box/box.test.js

Storybook

  • Go to the latest build of the storybook in this PR
  • Search for Box in UI
  • Check the stories, controls, and documentation

Pre-Merge Checklist

  • PR template is filled out
  • IF this PR fixes a bug, a test that would have caught the bug has been added
  • PR is linked to the appropriate GitHub issue
  • PR has been added to the appropriate release Milestone

+ If there are functional changes:

  • Manual testing complete & passed
  • "Extension QA Board" label has been applied

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
bbehrman10 Ben Behrman
@NidhiKJha NidhiKJha requested a review from a team as a code owner November 14, 2022 16:06
@NidhiKJha NidhiKJha requested review from mcmire, garrettbear and georgewrmarshall and removed request for mcmire November 14, 2022 16:06
brad-decker
brad-decker previously approved these changes Nov 14, 2022
@NidhiKJha NidhiKJha added area-UI Relating to the user interface. team-design-system All issues relating to design system in Extension labels Nov 14, 2022
@metamaskbot
Copy link
Collaborator

Builds ready [5761e31]
Page Load Metrics (2210 ± 152 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint9893414718187
domContentLoaded170333752203319153
load170333752210317152
domInteractive170333752203319153
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 bytes
  • ui: 0 bytes
  • common: 12 bytes

highlights:

storybook

Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 💯

  • checked storybook controls ✅
  • checked storybook MDX docs ✅
  • checked console ✅
  • ran unit tests locally ✅

I did run into an issue with the the responsive props not working for borderRadius prop but it may have never worked which is on me. I've created an issue #16491

@georgewrmarshall georgewrmarshall merged commit 780728d into develop Nov 14, 2022
@georgewrmarshall georgewrmarshall deleted the fix-16145 branch November 14, 2022 21:40
@github-actions github-actions bot locked and limited conversation to collaborators Nov 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-UI Relating to the user interface. team-design-system All issues relating to design system in Extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add 50% border radius support to the Box component
5 participants