-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added 50% border radius support to the Box component #16486
Merged
Merged
+86
−59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NidhiKJha
requested review from
mcmire,
garrettbear and
georgewrmarshall
and removed request for
mcmire
November 14, 2022 16:06
brad-decker
previously approved these changes
Nov 14, 2022
NidhiKJha
added
area-UI
Relating to the user interface.
team-design-system
All issues relating to design system in Extension
labels
Nov 14, 2022
darkwing
approved these changes
Nov 14, 2022
brad-decker
approved these changes
Nov 14, 2022
georgewrmarshall
approved these changes
Nov 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 💯
- checked storybook controls ✅
- checked storybook MDX docs ✅
- checked console ✅
- ran unit tests locally ✅
I did run into an issue with the the responsive props not working for borderRadius
prop but it may have never worked which is on me. I've created an issue #16491
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area-UI
Relating to the user interface.
team-design-system
All issues relating to design system in Extension
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to add 50% border-radius support to the box component for the circle UI
After
Manual Testing Steps
yarn test:unit:jest .ui/components/ui/box/box.test.js
Storybook
Pre-Merge Checklist
+ If there are functional changes: