Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 50% border radius support to the Box component #16145

Closed
georgewrmarshall opened this issue Oct 10, 2022 · 0 comments · Fixed by #16486
Closed

Add 50% border radius support to the Box component #16145

georgewrmarshall opened this issue Oct 10, 2022 · 0 comments · Fixed by #16486
Assignees
@NidhiKJha
Labels
area-UI Relating to the user interface. team-design-system All issues relating to design system in Extension

Comments

@georgewrmarshall
Copy link
Contributor

Description

It would make sense to add 50% border radius support to the box component for circle UI

Technical Details

  • Add logic for 50% border radius support to Box component
  • Update storybook
  • Update docs in mdx file

Acceptance Criteria

  • If BORDER_RADIUS.FULL is passed to Box component show 50% border radius
@georgewrmarshall georgewrmarshall added area-UI Relating to the user interface. team-design-system All issues relating to design system in Extension labels Oct 10, 2022
@georgewrmarshall georgewrmarshall self-assigned this Oct 10, 2022
@NidhiKJha NidhiKJha mentioned this issue Nov 14, 2022
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NidhiKJha NidhiKJha

Labels
area-UI Relating to the user interface. team-design-system All issues relating to design system in Extension
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

added 50% border radius support to the Box component MetaMask/metamask-extension
2 participants
@georgewrmarshall @NidhiKJha