Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Box component broken responsive props for border radius #16491

Closed
georgewrmarshall opened this issue Nov 14, 2022 · 0 comments · Fixed by #16510
Closed

Fix: Box component broken responsive props for border radius #16491

georgewrmarshall opened this issue Nov 14, 2022 · 0 comments · Fixed by #16510
Assignees
Labels
area-UI Relating to the user interface. team-design-system All issues relating to design system in Extension type-bug

Comments

@georgewrmarshall
Copy link
Contributor

georgewrmarshall commented Nov 14, 2022

Description

The responsive props for the borderRadius prop aren't working (and may have never worked mb! 🤦 ). The classNames are added correctly in the html but it seems the sass isn't properly generated. It might be worth adding border radius to ui/css/design-system/attributes.scss something like:

// in ui/css/design-system/attributes.scss

$border-radius: (
  none: 0,
  xs: 2px,
  md: 4px,
  lg: 8px,
  xl: 12px,
  full: 50%,
  pill: 9999px
);

Screencast

Story below has responsive props for borderRadius on all boxes. The classNames are being added to the html but the styles are not being generated

border.radius.broken.mov

While we are at it we should be consistent with pixels. This update should consolidate these values anyway

Screen Shot 2022-11-14 at 3 39 10 PM

@georgewrmarshall georgewrmarshall added type-bug area-UI Relating to the user interface. team-design-system All issues relating to design system in Extension labels Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-UI Relating to the user interface. team-design-system All issues relating to design system in Extension type-bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants