-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Failed transaction (eth-js rpc error) when speeding up a transaction #9317
Comments
Same error in MM 8.0.8 Chrome Version 85.0.4183.83 (Official Build) (64-bit) |
I also have the same issue with MM 8.0.8 and Brave Version 1.13.82. It is random as sometimes it works, sometimes not. I would say it fails 75% of the time and quite often with ledger wallet interaction. This is terrible user experience as when the error occur we cannot interact with the transaction anymore it just says failed. I have to manually speed the transaction via myetherwallet which is pretty difficult and cumbersome. |
same thing |
Facing the same issue on Chrome Version 85.0.4183.102 (Official Build) (64-bit). Tried to speed up an transaction underestimated by metamask, and tried speed up with average, then retry with high afterwards. |
Same thing, just cost me a lot of money |
Will this be fixed any time soon? Even if I tried create a new transaction with the same nonce, it failed, sometimes it works. |
Hopefully with more people reporting this issue this will get more visibility. This is in my opinion quite a big issue as once the transaction is failed when speeding up it is stuck without being able to do anything.. |
Same thing just happened to me. |
One thing that might fix temporary is to reset metamask (Settings -> Advanced -> Reset). This reset the transactions history not your seed. |
Related to #9053 |
Thanks for the report! Is anyone still able to reproduce this on the latest version of MetaMask? I tried speeding up a few transactions and didn't encounter this. |
I've encountered the same error with the speed up button and when doing it manually, ie change the nonce to the tx I want to speed up. It seems though that if I enter a gas price above a certain level it goes through. For example, I had a tx at 124 gwei. Then I sped it up at 138. My attempts to speed it up further (manually) with a new tx failed when I entered gas prices in the range 140-150, but it went through when I entered 154 gwei. Chrome version: 88.0.4324.150 |
Yes, I haven't faced the exact issue since then either, and I conjecture that it's as the above poster suggested... there seems to be a minimum gas fee increase requirement of 10%. Not sure if this is an infura limitation or something else, haven't been able to find a source that explains it. Now there is a new error that comes back specifically states the increase is not enough - so it is a different error message than when the bug was originally submitted (infura API perhaps updated to return a clearer message?). I cannot recall if I tested this via the wallet or via uniswap. |
i think time its come for switch wallet.. thanks metamask but because of this error i reset my acc 2times and lost all authorization for spend tokens the fees is too much now.. cya |
i am doing speed up transaction and it is showing error message of nonce and speed up doesnt happen any solution |
It is not working for me. For me all transaction failed with "Error: [ethjs-query] while formatting outputs from RPC" Code - 32602. |
This issue has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 45 days if there is no further activity. The MetaMask team intends on reviewing this issue before close, and removing the stale label if it is still a bug. We welcome new comments on this issue. We do not intend on closing issues if they report bugs that are still reproducible. Thank you for your contributions. |
## **Description** Our fork of ethjs-query has been namespaced to the `@metamask/` namespace, and updated with mostly development only fixes. There is one exception which is the reason for this pull request which is the removal of a try/catch that was catching too broadly and wrapping legitimate errors in a new Error object that claimed the issue was with the formatting of the output. In most cases this is incorrect and results in a wide swath of errors being lumped together inside of sentry. This change will result in the real errors being surfaced, after which we can decide where to prioritize efforts to resolve RPC issues. This PR progresses, and is expected to change the stack trace for the following issues: #9317 #10519 #10619 #11488 #11974 #13395 #14298 #14365 #15250 #17073 #17803 #19697 #20699 We are closing these issues opened automatically by sentry-io which are not fully resolved but should result in better errors and stack traces: fixes #10552 fixes #14660 fixes #14676 fixes #14730 fixes #14801 fixes #15065 ## **Manual testing steps** 1. Attempt to reproduce any of the bugs listed, 17073 was the easiest to reproduce for me. This involves getting test currency from the wemix faucet as listed in the issue and initiating a transaction between two accounts you own. 2. On develop you'll see an 'error formatting outputs' error text similar to what is reported in the issue. 3. On this branch you'll get the original error, without the wrapped 'formatting' error. including a different stack trace. ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [x] I've clearly explained: - [x] What problem this PR is solving. - [x] How this problem was solved. - [x] How reviewers can test my changes. - [x] I’ve indicated what issue this PR is linked to: Fixes #??? - [x] I’ve included tests if applicable. - [x] I’ve documented any added code. - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). - [x] I’ve properly set the pull request status: - [ ] In case it's not yet "ready for review", I've set it to "draft". - [x] In case it's "ready for review", I've changed it from "draft" to "non-draft". ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: MetaMask Bot <[email protected]>
This issue was closed because there has been no follow up activity in the last 45 days. If you feel this was closed in error, please reopen and provide evidence on the latest release of the extension. Thank you for your contributions. |
Describe the bug
Speeding up a transaction (with new custom gas price value) results in a failed transaction message every time, instead of sending the updated transaction.
To Reproduce
Expected behavior
The updated transaction is sent and Metamask registers the change
Browser details:
Mozilla Firefox 68.12.0esr (64-bit)
MetaMask 8.0.9
The text was updated successfully, but these errors were encountered: