Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error: [ethjs-query] while formatting outputs from RPC '{"value":{"code":-32000,"message":"already known..._Last 30 Days: 23 #14660

Closed
sentry-io bot opened this issue May 9, 2022 · 1 comment · Fixed by #21035
Closed

Error: [ethjs-query] while formatting outputs from RPC '{"value":{"code":-32000,"message":"already known..._Last 30 Days: 23 #14660

sentry-io bot opened this issue May 9, 2022 · 1 comment · Fixed by #21035
Labels
area-Sentry error reporting to sentry release-11.3.0 Issue or pull request that will be included in release 11.3.0 stability team-extension-platform
Milestone
Sentry-Error

Comments

@sentry-io
Copy link

sentry-io bot commented May 9, 2022 •
edited by hilvmason
Loading

Sentry Issue: METAMASK-H2FG

Error: [ethjs-query] while formatting outputs from RPC '{"value":{"code":-32000,"message":"already known"}}'

Last 30 Days: 23
@seaona
Copy link
Contributor

seaona commented May 9, 2022

This issue happens when the user sends a tx with a High priority fee and then tries to accelerate the tx selecting the same High priority fee.

Steps to reproduce:

  1. Send tx with a High priority fee
  2. Accelerate the tx and select the same High priority fee
accelerate-already-known.mp4

@danjm danjm added this to the Sentry-Error milestone May 9, 2022
@bschorchit bschorchit added the area-Sentry error reporting to sentry label May 9, 2022
@hilvmason hilvmason changed the title Error: [ethjs-query] while formatting outputs from RPC '{"value":{"code":-32000,"message":"already known... Error: [ethjs-query] while formatting outputs from RPC '{"value":{"code":-32000,"message":"already known..._Last 30 Days: 23 May 24, 2022
@brad-decker brad-decker mentioned this issue Sep 25, 2023
Merged
14 tasks
brad-decker added a commit that referenced this issue Sep 26, 2023
@brad-decker @metamaskbot
update ethjs-query to @metamask/ethjs-query (#21035)
ac5bdba 
## **Description**
Our fork of ethjs-query has been namespaced to the `@metamask/`
namespace, and updated with mostly development only fixes. There is one
exception which is the reason for this pull request which is the removal
of a try/catch that was catching too broadly and wrapping legitimate
errors in a new Error object that claimed the issue was with the
formatting of the output. In most cases this is incorrect and results in
a wide swath of errors being lumped together inside of sentry. This
change will result in the real errors being surfaced, after which we can
decide where to prioritize efforts to resolve RPC issues.

This PR progresses, and is expected to change the stack trace for the
following issues:
#9317 
#10519 
#10619
#11488 
#11974 
#13395 
#14298 
#14365 
#15250 
#17073 
#17803 
#19697 
#20699 

We are closing these issues opened automatically by sentry-io which are
not fully resolved but should result in better errors and stack traces:

fixes #10552 
fixes #14660 
fixes #14676 
fixes #14730 
fixes #14801
fixes #15065 

## **Manual testing steps**
1. Attempt to reproduce any of the bugs listed, 17073 was the easiest to
reproduce for me. This involves getting test currency from the wemix
faucet as listed in the issue and initiating a transaction between two
accounts you own.
2. On develop you'll see an 'error formatting outputs' error text
similar to what is reported in the issue.
3. On this branch you'll get the original error, without the wrapped
'formatting' error. including a different stack trace.

## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've clearly explained:
  - [x] What problem this PR is solving.
  - [x] How this problem was solved.
  - [x] How reviewers can test my changes.
- [x] I’ve indicated what issue this PR is linked to: Fixes #???
- [x] I’ve included tests if applicable.
- [x] I’ve documented any added code.
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
- [x] I’ve properly set the pull request status:
  - [ ] In case it's not yet "ready for review", I've set it to "draft".
- [x] In case it's "ready for review", I've changed it from "draft" to
"non-draft".

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

---------

Co-authored-by: MetaMask Bot <[email protected]>
@metamaskbot metamaskbot added the release-11.3.0 Issue or pull request that will be included in release 11.3.0 label Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-Sentry error reporting to sentry release-11.3.0 Issue or pull request that will be included in release 11.3.0 stability team-extension-platform
Projects
None yet
Milestone
Sentry-Error
Development

Successfully merging a pull request may close this issue.

update ethjs-query to @metamask/ethjs-query MetaMask/metamask-extension
6 participants
@gauthierpetetin @danjm @bschorchit @metamaskbot @seaona @hilvmason