Skip to content

Commit

Permalink
E2e remove redundant code (#16432)
Browse files Browse the repository at this point in the history
* remove unused code

* remove unused code
  • Loading branch information
PeterYinusa authored Nov 9, 2022
1 parent 6ff8044 commit 07b39de
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 33 deletions.
16 changes: 8 additions & 8 deletions test/e2e/metamask-ui.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -458,10 +458,10 @@ describe('MetaMask', function () {
await driver.delay(veryLargeDelayMs);
await driver.clickElement({ text: 'Edit', tag: 'button' });
await driver.delay(veryLargeDelayMs);
await driver.clickElement(
{ text: 'Edit suggested gas fee', tag: 'button' },
10000,
);
await driver.clickElement({
text: 'Edit suggested gas fee',
tag: 'button',
});
await driver.delay(veryLargeDelayMs);
const inputs = await driver.findElements('input[type="number"]');
const gasLimitInput = inputs[0];
Expand Down Expand Up @@ -576,10 +576,10 @@ describe('MetaMask', function () {
it('customizes gas', async function () {
await driver.clickElement('.confirm-approve-content__small-blue-text');
await driver.delay(regularDelayMs);
await driver.clickElement(
{ text: 'Edit suggested gas fee', tag: 'button' },
10000,
);
await driver.clickElement({
text: 'Edit suggested gas fee',
tag: 'button',
});
await driver.delay(regularDelayMs);

const [gasLimitInput, gasPriceInput] = await driver.findElements(
Expand Down
8 changes: 4 additions & 4 deletions test/e2e/tests/custom-token-add-approve.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -221,10 +221,10 @@ describe.skip('Create token, approve token and approve token without gas', funct
await driver.clickElement(
'.confirm-approve-content__small-blue-text',
);
await driver.clickElement(
{ text: 'Edit suggested gas fee', tag: 'button' },
10000,
);
await driver.clickElement({
text: 'Edit suggested gas fee',
tag: 'button',
});
const [gasLimitInput, gasPriceInput] = await driver.findElements(
'input[type="number"]',
);
Expand Down
25 changes: 4 additions & 21 deletions test/e2e/tests/send-eth.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -239,23 +239,6 @@ describe('Send ETH from dapp using advanced gas controls', function () {
await driver.fill('#password', 'correct horse battery staple');
await driver.press('#password', driver.Key.ENTER);

// goes to the settings screen
await driver.clickElement('.account-menu__icon');
await driver.clickElement({ text: 'Settings', tag: 'div' });
await driver.clickElement({ text: 'Advanced', tag: 'div' });
await driver.clickElement(
'[data-testid="advanced-setting-show-testnet-conversion"] .settings-page__content-item-col > label > div',
);
const advancedGasTitle = await driver.findElement({
text: 'Advanced gas controls',
tag: 'span',
});
await driver.scrollToElement(advancedGasTitle);
await driver.clickElement(
'[data-testid="advanced-setting-advanced-gas-inline"] .settings-page__content-item-col > label > div',
);
await driver.clickElement('.app-header__logo-container');

// initiates a send from the dapp
await driver.openNewPage('http://127.0.0.1:8080/');
await driver.clickElement({ text: 'Send', tag: 'button' });
Expand All @@ -272,10 +255,10 @@ describe('Send ETH from dapp using advanced gas controls', function () {
css: '.transaction-total-banner',
text: '0.00021 ETH',
});
await driver.clickElement(
{ text: 'Edit suggested gas fee', tag: 'button' },
10000,
);
await driver.clickElement({
text: 'Edit suggested gas fee',
tag: 'button',
});
await driver.waitForSelector({
css: '.transaction-total-banner',
text: '0.00021 ETH',
Expand Down

0 comments on commit 07b39de

Please sign in to comment.