Skip to content

Commit

Permalink
Remove obsolete builds (#16430)
Browse files Browse the repository at this point in the history
The `brave` and `opera` builds are obsolete; in practice we have been
using the Chrome build for those browsers, because they are based upon
Chromium and are compatible with the Chrome extension API.
  • Loading branch information
Gudahtt authored Nov 9, 2022
1 parent 328626d commit 6ff8044
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 2 deletions.
2 changes: 1 addition & 1 deletion development/build/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ async function defineAndRunBuildTasks() {
version,
} = await parseArgv();

const browserPlatforms = ['firefox', 'chrome', 'brave', 'opera'];
const browserPlatforms = ['firefox', 'chrome'];

const browserVersionMap = getBrowserVersionMap(browserPlatforms, version);

Expand Down
2 changes: 1 addition & 1 deletion development/metamaskbot-build-announce.js
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ async function start() {
// build the github comment content

// links to extension builds
const platforms = ['chrome', 'firefox', 'opera'];
const platforms = ['chrome', 'firefox'];
const buildLinks = platforms
.map((platform) => {
const url = `${BUILD_LINK_BASE}/builds/metamask-${platform}-${VERSION}.zip`;
Expand Down
1 change: 1 addition & 0 deletions docs/QA_Guide.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

Steps to mark a full pass of QA complete.
* Browsers: Opera, Chrome, Firefox, Edge.
* Use the Chrome build for all Chromium-derived browsers (e.g. Opera and Edge)
* OS: Ubuntu, Mac OSX, Windows
* Load older version of MetaMask and attempt to simulate updating the extension.
* Open Developer Console in background and popup, inspect errors.
Expand Down

0 comments on commit 6ff8044

Please sign in to comment.